This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
fix(TypeScript): add grid and gridTemplate
#403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 177 177
Branches 50 50
=====================================
Hits 177 177Continue to review full report at Codecov.
|
Ailrun
suggested changes
Apr 2, 2018
typings/css-properties.d.ts
Outdated
| /** | ||
| * Shorthand property that sets the grid-template-rows, grid-template-columns, and grid-template-areas. | ||
| */ | ||
| gridTemplate?: CSSWideKeyword | string | 'none' |
There was a problem hiding this comment.
string | 'none' is just a string type. Please remove 'none'.
Ailrun
approved these changes
Apr 4, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
fix #402
Why:
N/A
How:
https://developer.mozilla.org/en-US/docs/Web/CSS/grid
https://developer.mozilla.org/en-US/docs/Web/CSS/grid-template
Checklist: