Add CSV support #16
Closed
Add CSV support #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppai-plivo
commented
Apr 8, 2020
| @@ -4,6 +4,7 @@ const fs = require('fs'); | |||
| const path = require('path'); | |||
| const jsdom = require('jsdom'); | |||
| const { JSDOM } = jsdom; | |||
| const csvstringify = require('csv-stringify/lib/sync') | |||
There was a problem hiding this comment.
As documented here: https://csv.js.org/stringify/api/#sync-api
|
@pbakondy please let me know if this is ok. |
|
@ppai-plivo please include only the code changes without the generated files in your patch |
Done 👍 I hope that next time you run |
|
@pbakondy Can you please take a look again ? Thanks. |
Running `fetch.js` now also generates `mcc-mnc-list.csv` file. Signed-off-by: Prashanth Pai <prashanth.pai@plivo.com>
ppai-plivo
force-pushed
the
csv-support
branch
from
7ea1907
to
6222406
Compare
|
Bump! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
fetch.jsnow also generatesmcc-mnc-list.csvfile.$ ls -lh mcc-mnc-list.* -rw-r--r-- 1 user staff 283K Apr 8 13:36 mcc-mnc-list.csv -rw-r--r-- 1 user staff 763K Apr 8 13:23 mcc-mnc-list.jsonCloses: #15