Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: make pre-release notes script check if EDITOR is set #344

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

nstelter-slac
Copy link
Contributor

@nstelter-slac nstelter-slac commented Aug 26, 2024

Description

Motivation and Context

closes #326

How Has This Been Tested?

Tested manually

Where Has This Been Documented?

don't think it's necessary for this

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@nstelter-slac
Copy link
Contributor Author

nstelter-slac commented Aug 26, 2024

should prob also update the other pre-release scripts b4 closing issue: https://github.com/search?q=org%3Apcdshub+if+%24%7BEDITOR%7D&type=code

@nstelter-slac nstelter-slac force-pushed the pre_release_default_editor branch from 3cc419a to f8b14f2 Compare August 27, 2024 17:30
@nstelter-slac
Copy link
Contributor Author

nstelter-slac commented Aug 27, 2024

actually lets just only also update cookie-cutter for now: pcdshub/cookiecutter-pcds-python#55

@nstelter-slac nstelter-slac marked this pull request as ready for review September 24, 2024 04:07
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible and helpful default

@ZLLentz
Copy link
Member

ZLLentz commented Sep 25, 2024

Merging once the CI finishes churning

Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Cookiecutter changes won't immediately propagate to all our packages, but that's ok and doesn't stop this from being mergable

@ZLLentz ZLLentz merged commit 90a24e2 into pcdshub:master Sep 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-release notes script does not check if EDITOR is unset
3 participants