Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_token not working on private repo #377

Closed
chatziko opened this issue Jul 5, 2020 · 3 comments
Closed

github_token not working on private repo #377

chatziko opened this issue Jul 5, 2020 · 3 comments
Assignees
Labels
bug Something isn't working resolved

Comments

@chatziko
Copy link

chatziko commented Jul 5, 2020

github_token are supposed to work with private repos since some time now, but the following config is not working reliably.

    - name: Deploy
      uses: peaceiris/actions-gh-pages@v3
      with:
        github_token: ${{ secrets.GITHUB_TOKEN }}
        publish_branch: master
        publish_dir: ./public
        force_orphan: true

What happens:

  • the action runs succesfully
  • the correct output is pushed correctly in the master branch
  • the gihub pages Activity log shows that the new version is deployed
  • but the old version is still served
    • not always, but with substantially high probability (say 30-50% of the time)
  • if I manually commit any file in the master branch the new version is immediately served.
  • setting force_orphan: false does not fix the issue

For now I'm switching back to deploy_key, but it would be super neat to fix this.

@chatziko chatziko added the bug Something isn't working label Jul 5, 2020
@peaceiris
Copy link
Owner

Thank you for reporting. Duplicate of #349

@peaceiris
Copy link
Owner

#349 was closed.

@github-actions
Copy link
Contributor

This issue has been LOCKED because of it being resolved!

The issue has been fixed and is therefore considered resolved.
If you still encounter this or it has changed, open a new issue instead of responding to solved ones.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working resolved
Projects
None yet
Development

No branches or pull requests

2 participants