Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local url-for from any samples. #33

Open
avescodes opened this issue Jul 14, 2013 · 3 comments
Open

Remove local url-for from any samples. #33

avescodes opened this issue Jul 14, 2013 · 3 comments
Labels

Comments

@avescodes
Copy link

From pedestal/pedestal#114, we would like to remove the usage of local url-for definitions in any samples where they occur.

@clojens
Copy link

clojens commented Sep 9, 2013

These are automatically accounted for, meaning they can just be removed or does something else need to change with it? Service template still generates these.

@avescodes
Copy link
Author

I'd say the process should be:

  1. Complete Remove local url-for from service template and samples pedestal#114 (remove url-for from templates and verify everything is still peachy)
  2. Re-generate service samples w/o def url-for

@clojens
Copy link

clojens commented Sep 11, 2013

Yeah that's what I'm doing anyway, seems there is nothing broken due to that so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants