From 3a5511e716ec4441904f20fbc64f9792e1c304de Mon Sep 17 00:00:00 2001 From: locoe Date: Fri, 21 Jun 2024 16:44:37 -0400 Subject: [PATCH 1/6] BUG-872590 added ephemeralStorage options in pega installer image --- .../pega/charts/installer/templates/_pega-installer-job.tpl | 2 ++ charts/pega/charts/installer/values.yaml | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/charts/pega/charts/installer/templates/_pega-installer-job.tpl b/charts/pega/charts/installer/templates/_pega-installer-job.tpl index 726d27e9d..ed24c3550 100644 --- a/charts/pega/charts/installer/templates/_pega-installer-job.tpl +++ b/charts/pega/charts/installer/templates/_pega-installer-job.tpl @@ -112,9 +112,11 @@ spec: requests: cpu: "{{ .root.Values.resources.requests.cpu }}" memory: "{{ .root.Values.resources.requests.memory }}" + ephemeral-storage: "{{ .root.Values.resources.requests.ephemeralStorage }}" limits: cpu: "{{ .root.Values.resources.limits.cpu }}" memory: "{{ .root.Values.resources.limits.memory }}" + ephemeral-storage: "{{ .root.Values.resources.limits.ephemeralStorage }}" volumeMounts: {{- if .root.Values.installerMountVolumeClaimName }} - name: {{ template "pegaInstallerMountVolume" }} diff --git a/charts/pega/charts/installer/values.yaml b/charts/pega/charts/installer/values.yaml index fb7ad3d1a..8262324a3 100644 --- a/charts/pega/charts/installer/values.yaml +++ b/charts/pega/charts/installer/values.yaml @@ -83,14 +83,17 @@ upgrade: # Specify automaticResumeEnabled to support resuming rules_upgrade from point of failure. You can use this functionality only when you use "custom" upgradeType. automaticResumeEnabled: "false" -# Memory and CPU settings for installer +# Memory, CPU, and ephemeral storage settings for installer +# Ephemeral storage recommended size is 10G resources: requests: memory: "5Gi" cpu: 1 + ephemeralStorage: "" limits: memory: "6Gi" cpu: 2 + ephemeralStorage: "" shareProcessNamespace: false From 9babb130e5f9fe3a388705e858648eb40fee4abc Mon Sep 17 00:00:00 2001 From: locoe Date: Tue, 25 Jun 2024 14:06:50 -0400 Subject: [PATCH 2/6] BUG-872590 setting defaults to ephemeralStorage --- .../pega/charts/installer/templates/_pega-installer-job.tpl | 4 ++-- charts/pega/charts/installer/values.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/charts/pega/charts/installer/templates/_pega-installer-job.tpl b/charts/pega/charts/installer/templates/_pega-installer-job.tpl index ed24c3550..8b20ee4d4 100644 --- a/charts/pega/charts/installer/templates/_pega-installer-job.tpl +++ b/charts/pega/charts/installer/templates/_pega-installer-job.tpl @@ -112,11 +112,11 @@ spec: requests: cpu: "{{ .root.Values.resources.requests.cpu }}" memory: "{{ .root.Values.resources.requests.memory }}" - ephemeral-storage: "{{ .root.Values.resources.requests.ephemeralStorage }}" + ephemeral-storage: "{{ .root.Values.resources.requests.ephemeralStorage | default \"\" }}" limits: cpu: "{{ .root.Values.resources.limits.cpu }}" memory: "{{ .root.Values.resources.limits.memory }}" - ephemeral-storage: "{{ .root.Values.resources.limits.ephemeralStorage }}" + ephemeral-storage: "{{ .root.Values.resources.limits.ephemeralStorage | default \"\" }}" volumeMounts: {{- if .root.Values.installerMountVolumeClaimName }} - name: {{ template "pegaInstallerMountVolume" }} diff --git a/charts/pega/charts/installer/values.yaml b/charts/pega/charts/installer/values.yaml index 8262324a3..79468b085 100644 --- a/charts/pega/charts/installer/values.yaml +++ b/charts/pega/charts/installer/values.yaml @@ -89,11 +89,11 @@ resources: requests: memory: "5Gi" cpu: 1 - ephemeralStorage: "" +# ephemeralStorage: "" limits: memory: "6Gi" cpu: 2 - ephemeralStorage: "" +# ephemeralStorage: "" shareProcessNamespace: false From d71afea8794bdbca6c89bd0187faa614d0a503d2 Mon Sep 17 00:00:00 2001 From: locoe Date: Tue, 25 Jun 2024 14:24:09 -0400 Subject: [PATCH 3/6] BUG-872590 fixing indentation --- charts/pega/charts/installer/values.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/pega/charts/installer/values.yaml b/charts/pega/charts/installer/values.yaml index 79468b085..579c44dd1 100644 --- a/charts/pega/charts/installer/values.yaml +++ b/charts/pega/charts/installer/values.yaml @@ -89,11 +89,11 @@ resources: requests: memory: "5Gi" cpu: 1 -# ephemeralStorage: "" + # ephemeralStorage: "" limits: memory: "6Gi" cpu: 2 -# ephemeralStorage: "" + # ephemeralStorage: "" shareProcessNamespace: false From f26465f23b19a43296ed5939cbcfadc0798f2d6d Mon Sep 17 00:00:00 2001 From: locoe Date: Tue, 25 Jun 2024 14:30:42 -0400 Subject: [PATCH 4/6] BUG-872590 fixing default value --- .../pega/charts/installer/templates/_pega-installer-job.tpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/pega/charts/installer/templates/_pega-installer-job.tpl b/charts/pega/charts/installer/templates/_pega-installer-job.tpl index 8b20ee4d4..d58247328 100644 --- a/charts/pega/charts/installer/templates/_pega-installer-job.tpl +++ b/charts/pega/charts/installer/templates/_pega-installer-job.tpl @@ -112,11 +112,11 @@ spec: requests: cpu: "{{ .root.Values.resources.requests.cpu }}" memory: "{{ .root.Values.resources.requests.memory }}" - ephemeral-storage: "{{ .root.Values.resources.requests.ephemeralStorage | default \"\" }}" + ephemeral-storage: "{{ .root.Values.resources.requests.ephemeralStorage | default '' }}" limits: cpu: "{{ .root.Values.resources.limits.cpu }}" memory: "{{ .root.Values.resources.limits.memory }}" - ephemeral-storage: "{{ .root.Values.resources.limits.ephemeralStorage | default \"\" }}" + ephemeral-storage: "{{ .root.Values.resources.limits.ephemeralStorage | default '' }}" volumeMounts: {{- if .root.Values.installerMountVolumeClaimName }} - name: {{ template "pegaInstallerMountVolume" }} From 860bdde81192948af98b0ad6eedb992fc18e86b9 Mon Sep 17 00:00:00 2001 From: locoe Date: Tue, 25 Jun 2024 14:35:34 -0400 Subject: [PATCH 5/6] BUG-872590 fixing default value --- .../pega/charts/installer/templates/_pega-installer-job.tpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/pega/charts/installer/templates/_pega-installer-job.tpl b/charts/pega/charts/installer/templates/_pega-installer-job.tpl index d58247328..0d9720075 100644 --- a/charts/pega/charts/installer/templates/_pega-installer-job.tpl +++ b/charts/pega/charts/installer/templates/_pega-installer-job.tpl @@ -112,11 +112,11 @@ spec: requests: cpu: "{{ .root.Values.resources.requests.cpu }}" memory: "{{ .root.Values.resources.requests.memory }}" - ephemeral-storage: "{{ .root.Values.resources.requests.ephemeralStorage | default '' }}" + ephemeral-storage: "{{ .root.Values.resources.requests.ephemeralStorage | default "" }}" limits: cpu: "{{ .root.Values.resources.limits.cpu }}" memory: "{{ .root.Values.resources.limits.memory }}" - ephemeral-storage: "{{ .root.Values.resources.limits.ephemeralStorage | default '' }}" + ephemeral-storage: "{{ .root.Values.resources.limits.ephemeralStorage | default "" }}" volumeMounts: {{- if .root.Values.installerMountVolumeClaimName }} - name: {{ template "pegaInstallerMountVolume" }} From 18105ac82eeb464c1164d960454ed515e6683c1a Mon Sep 17 00:00:00 2001 From: locoe Date: Tue, 25 Jun 2024 14:49:09 -0400 Subject: [PATCH 6/6] BUG-872590 fixing default value --- .../pega/charts/installer/templates/_pega-installer-job.tpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/pega/charts/installer/templates/_pega-installer-job.tpl b/charts/pega/charts/installer/templates/_pega-installer-job.tpl index 0d9720075..dffba31d8 100644 --- a/charts/pega/charts/installer/templates/_pega-installer-job.tpl +++ b/charts/pega/charts/installer/templates/_pega-installer-job.tpl @@ -112,11 +112,11 @@ spec: requests: cpu: "{{ .root.Values.resources.requests.cpu }}" memory: "{{ .root.Values.resources.requests.memory }}" - ephemeral-storage: "{{ .root.Values.resources.requests.ephemeralStorage | default "" }}" + ephemeral-storage: "{{ .root.Values.resources.requests.ephemeralStorage | default "0G" }}" limits: cpu: "{{ .root.Values.resources.limits.cpu }}" memory: "{{ .root.Values.resources.limits.memory }}" - ephemeral-storage: "{{ .root.Values.resources.limits.ephemeralStorage | default "" }}" + ephemeral-storage: "{{ .root.Values.resources.limits.ephemeralStorage | default "0G" }}" volumeMounts: {{- if .root.Values.installerMountVolumeClaimName }} - name: {{ template "pegaInstallerMountVolume" }}