Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip importing OSM #290

Open
emacgillavry opened this issue Aug 25, 2022 · 2 comments
Open

Skip importing OSM #290

emacgillavry opened this issue Aug 25, 2022 · 2 comments
Labels

Comments

@emacgillavry
Copy link

With c7122d5, we can no longer skip importing OSM into the address.db. We have custom countrywide.csv and polylines.0sv files and were able to obtain the address.db and street.db database files without any need for an OSM data file. Can we add configuration to pelias.json so interpolation would know what inputs to skip?

Current kludge is to provide an empty netherlands-latest.osm.pbf file

@missinglink
Copy link
Member

Agh I didn't consider that case, I suspect that having the configuration in pelias.json would be hard to pass down to this bash script without considerable refactoring.

If I recall correctly, the intention of the fatal errors at the top of that bash script was to indicate to the user that the required files were missing, to save them the time & heartache of running the whole build before catching their error.

I wonder if we could change those fatal errors to warnings instead, and do nothing when no file is found.

@emacgillavry
Copy link
Author

From your suggestion we'd just drop the exit 1. The user would still receive feedback about the missing files, but the build would proceed: if the file is empty (the kludge we use now) or does not exist (our way of working before c7122d5) the build.sh script runs ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants