Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapper stream to separate concatenated unit numbers #502

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

missinglink
Copy link
Member

note: branched from #500

as noted in #499 some sources have the unit and housenumber concatenated.

this PR solves the issue for the most common cases in AU/NZ and opens up the possibility for expansion in other countries.

closes #499

@missinglink
Copy link
Member Author

this PR will be particularly helpful in Australia, currently we're seeing results like this:
https://pelias.github.io/compare/#/v1/search?text=10+brunswick+st%2C+fitzroy&debug=1

@missinglink missinglink force-pushed the unit-number-extractor branch 5 times, most recently from fe7d6a3 to 361a56f Compare February 3, 2022 12:11
@missinglink missinglink force-pushed the unit-number-extractor branch 2 times, most recently from 2a02967 to e78bc52 Compare February 3, 2022 12:46
@missinglink missinglink force-pushed the unit-number-extractor branch from e78bc52 to d20bc58 Compare February 3, 2022 12:50
@missinglink
Copy link
Member Author

This looks good-to-go, the results for /v1/search are markedly improved:

Screenshot 2022-02-07 at 13 53 34

Additionally the GNAF mapper is still working as expected:

Screenshot 2022-02-07 at 13 54 38

Worth noting that the results for /v1/autocomplete are still not great:

Screenshot 2022-02-07 at 13 54 02

This is mainly due to a decision I made to not modify the name.default (which is trivial to do).
The tradeoff here is that we would get similar results to /v1/search at the cost of the unit number not being included in the label, and therefore making visual deduplication more difficult.

I suggest we merge this as it's only positive and discuss a new ticket where we modify the name.default for these AU/NZ records in such a way that it doesn't include the unit designation, we can then modify the label generator to prepend in the unit number to the label in a locale-aware way.

@missinglink
Copy link
Member Author

acceptance tests looking 👍, merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

au: split unit and housenumber
1 participant