analysis: append ordinal suffix to numeric street names #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
force-pushed
the
analysis_add_ordinals
branch
from
038ad94 to
9cc1f81
Compare
missinglink
force-pushed
the
analysis_add_ordinals
branch
from
9cc1f81 to
8c5555a
Compare
|
This looks good, I tested it on a global build and it had several positive changes to our test suite, particularly in grid cities like NYC.
|
|
Yeah, this looks great. Very good change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following on from #477 et al, this is something we were missing which annoyed me.
it was a relatively simple task to add missing street ordinals to numeric street names.