Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible regex issue #94

Closed
missinglink opened this issue Jan 7, 2016 · 1 comment
Closed

possible regex issue #94

missinglink opened this issue Jan 7, 2016 · 1 comment
Assignees

Comments

@missinglink
Copy link
Member

The remove_ordinals regex seems to be wrong?

        "remove_ordinals" : {
          "type" : "pattern_replace",
          "pattern": "(([0-9])(st|nd|rd|th))",
          "replacement": "$2"
        },

this should really be (([0-9]+)(st|nd|rd|th)) (with a plus sign) shouldn't it?

the weird thing is the test is passing here: https://github.com/pelias/schema/blob/master/integration/analyzer_peliasStreet.js#L27

ref: https://github.com/pelias/schema/blob/master/settings.js#L151

@orangejulius
Copy link
Member

We fixed this in #96! 🍒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants