We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The remove_ordinals regex seems to be wrong?
remove_ordinals
"remove_ordinals" : { "type" : "pattern_replace", "pattern": "(([0-9])(st|nd|rd|th))", "replacement": "$2" },
this should really be (([0-9]+)(st|nd|rd|th)) (with a plus sign) shouldn't it?
(([0-9]+)(st|nd|rd|th))
the weird thing is the test is passing here: https://github.com/pelias/schema/blob/master/integration/analyzer_peliasStreet.js#L27
ref: https://github.com/pelias/schema/blob/master/settings.js#L151
The text was updated successfully, but these errors were encountered:
We fixed this in #96! 🍒
Sorry, something went wrong.
missinglink
Successfully merging a pull request may close this issue.
The
remove_ordinals
regex seems to be wrong?this should really be
(([0-9]+)(st|nd|rd|th))
(with a plus sign) shouldn't it?the weird thing is the test is passing here: https://github.com/pelias/schema/blob/master/integration/analyzer_peliasStreet.js#L27
ref: https://github.com/pelias/schema/blob/master/settings.js#L151
The text was updated successfully, but these errors were encountered: