Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for d3 version 4.x? #21

Open
jez opened this issue Feb 7, 2017 · 6 comments
Open

Support for d3 version 4.x? #21

jez opened this issue Feb 7, 2017 · 6 comments

Comments

@jez
Copy link

jez commented Feb 7, 2017

Last summer the D3 maintainers released a breaking API change, upgrading from 3.x to 4.x. While a lot of things between the new and old version are the same, many individualized APIs have changed.

Is there any plan to support D3 4.x? I'm using D3 for a project right now, and I'd love to be able to use PureScript for it. Right now the alternative is just to add the foreign functions for each new API that I call. Of course, the obvious downsides are

  1. the work would be isolated, and not abstracted into a library
  2. wouldn't cover the full range of the API like it might be if done in the context of purescript-d3 proper.
@pelotom
Copy link
Owner

pelotom commented Feb 7, 2017

Hi @jez, I've had my hands full with non-PureScript projects lately, and I can't say when I'll have time to work on this. Rather than adding a few isolated foreign functions within your own project, what about submitting a PR to migrate this library to 4.x?

@jez
Copy link
Author

jez commented Feb 7, 2017

Looks like a lot of work 😝 I'll consider it.

Makes total sense to be busy; honestly, I'm impressed you responded as quickly as you did!

I'll see if I feel motivated enough to port things over; maybe as I look at it they'll all have a similar form. My biggest concern though is that I won't be using most of the functions, and as such many would go untested.

@afcondon
Copy link

afcondon commented Feb 7, 2017

If either of you want to borrow from work i did here on (at first porting, then re-writing) this repo you're very welcome. That's the work i talked thru on purescript-unscripted.

Currently i'm trying a whole new approach which is in this repo.

@pelotom
Copy link
Owner

pelotom commented Feb 7, 2017

Wow, I didn't know about purescript-d3v4, looks nice!

@afcondon
Copy link

afcondon commented Feb 7, 2017

Thanks! I thought so too (was feeling pretty good about it) - and then i rather belatedly watched Phil Freeman's excellent talk on "finally tagless" parsers and realized that there's a much much better way to do this so that's what i'm working on now.

btw existence of and ease use/examples in your original lib (this repo) was what encouraged me to get into purescript so many thanks for that!

@pelotom
Copy link
Owner

pelotom commented Feb 7, 2017

You're very welcome. The finally tagless stuff sounds interesting, thanks for the links!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants