-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for d3 version 4.x? #21
Comments
Hi @jez, I've had my hands full with non-PureScript projects lately, and I can't say when I'll have time to work on this. Rather than adding a few isolated foreign functions within your own project, what about submitting a PR to migrate this library to 4.x? |
Looks like a lot of work 😝 I'll consider it. Makes total sense to be busy; honestly, I'm impressed you responded as quickly as you did! I'll see if I feel motivated enough to port things over; maybe as I look at it they'll all have a similar form. My biggest concern though is that I won't be using most of the functions, and as such many would go untested. |
Wow, I didn't know about |
Thanks! I thought so too (was feeling pretty good about it) - and then i rather belatedly watched Phil Freeman's excellent talk on "finally tagless" parsers and realized that there's a much much better way to do this so that's what i'm working on now. btw existence of and ease use/examples in your original lib (this repo) was what encouraged me to get into purescript so many thanks for that! |
You're very welcome. The finally tagless stuff sounds interesting, thanks for the links! |
Last summer the D3 maintainers released a breaking API change, upgrading from 3.x to 4.x. While a lot of things between the new and old version are the same, many individualized APIs have changed.
Is there any plan to support D3 4.x? I'm using D3 for a project right now, and I'd love to be able to use PureScript for it. Right now the alternative is just to add the foreign functions for each new API that I call. Of course, the obvious downsides are
purescript-d3
proper.The text was updated successfully, but these errors were encountered: