Support no_std #87
Merged
Support no_std #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
plaidfinch
suggested changes
Apr 5, 2023
There was a problem hiding this comment.
This looks very good!
The one blocker I think is the replacement of RwLock with RefCell in the MockTreeStore: I think we don't want this, because it limits the utility of the MockTreeStore. More on that below and possible different approach that preserves no_std.
A couple of thoughts about backwards compatibility: I think we do not need to preserve it, and we should break it while we can (i.e. while there are not downstream users other than ourselves). What do you think?
This commit allows the JMT to be used in no_std environments. The trie still requires alloc. To implement this functionality, two non-trivial changes are made. 1. Replace all custom serialization with Borsh. **This is a breaking change which alters the state roots computed by the JMT**. 2. Remove support for multithreaded testing from the provided mock tree store. This functionality was unused, but if desired it can be easily re-implemented behind a feature-gate. In addition, there are numerous minor changes to imports. Finally, the tries built-in metrics are gated behind the "metrics" feature.
A bug in the previous commit disabled all code when building with std. This commit removes the erroneous #![cfg(...)] and fixes some imports in the std version which caused builds to fail when the bug was fixed.
Remove test vector dep on std
plaidfinch
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the JMT to be used in no_std environments. The trie still requires alloc.
To implement this functionality, the following non-trivial changes are made:
Borshderives.This is a breaking change which alters the state roots computed by the JMT.Correction: serialization is only used for the database, so this change does not alter state rootsLegacyInternalNodeType.In addition, there are numerous minor changes to imports. Finally, the trie's built-in metrics are gated behind the "metrics" feature.