From 1a75c2a9407042b01aff729a0e824a5bad7e3f0c Mon Sep 17 00:00:00 2001 From: Conor Schaefer Date: Wed, 26 Apr 2023 12:53:51 -0700 Subject: [PATCH 1/2] pcli: readable ibc query error text Updates `pcli query ibc` commands to have a sprinkling of context, for human-readable error messages when lookups fail. --- pcli/src/command/query/ibc_query.rs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/pcli/src/command/query/ibc_query.rs b/pcli/src/command/query/ibc_query.rs index 260aa84bf8..700600eeb0 100644 --- a/pcli/src/command/query/ibc_query.rs +++ b/pcli/src/command/query/ibc_query.rs @@ -1,4 +1,4 @@ -use anyhow::Result; +use anyhow::{Context, Result}; use colored_json::prelude::*; use ibc_types::clients::ics07_tendermint::client_state::ClientState as TendermintClientState; use ibc_types::core::ics03_connection::connection::ConnectionEnd; @@ -31,7 +31,8 @@ impl IbcCmd { key, ..Default::default() }) - .await? + .await + .context(format!("Failed to find client {client_id}"))? .into_inner() .value; @@ -46,7 +47,8 @@ impl IbcCmd { key, ..Default::default() }) - .await? + .await + .context(format!("Failed to find connection {connection_id}"))? .into_inner() .value; @@ -61,7 +63,8 @@ impl IbcCmd { key, ..Default::default() }) - .await? + .await + .context(format!("Failed to find channel {port}:{channel_id}"))? .into_inner() .value; From a896e5645788c8a102f02a8164e88e02216a5427 Mon Sep 17 00:00:00 2001 From: Conor Schaefer Date: Thu, 27 Apr 2023 12:58:55 -0700 Subject: [PATCH 2/2] chain: enable ics20 transfers in default params Here we update the default chain params to enable ICS-20 inbound & outbound params. It doesn't appear we're actually checking this anywhere in our code, but I'm making the change in the context of pushing toward getting the relayer working for IBC transfers between preview & testnet. --- chain/src/params.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chain/src/params.rs b/chain/src/params.rs index bdcf94fc28..d3dfeda0fe 100644 --- a/chain/src/params.rs +++ b/chain/src/params.rs @@ -204,8 +204,8 @@ impl Default for ChainParameters { // 3bps -> 11% return over 365 epochs base_reward_rate: 3_0000, ibc_enabled: true, - inbound_ics20_transfers_enabled: false, - outbound_ics20_transfers_enabled: false, + inbound_ics20_transfers_enabled: true, + outbound_ics20_transfers_enabled: true, // governance proposal_voting_blocks: 17_280, // 24 hours, at a 5 second block time proposal_deposit_amount: 10_000_000u64.into(), // 10,000,000 upenumbra = 10 penumbra