From 6629765536c2acba135c26c4af6ed311403dce60 Mon Sep 17 00:00:00 2001 From: Amit Singh Sansoya Date: Thu, 3 Aug 2023 12:26:40 +0530 Subject: [PATCH] Adding support for legacy protocol (#1323) --- packages/webdriver-utils/src/metadata/mobileMetaData.js | 2 +- .../test/providers/genericProvider.test.js | 9 ++------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/packages/webdriver-utils/src/metadata/mobileMetaData.js b/packages/webdriver-utils/src/metadata/mobileMetaData.js index 25673314a..b85d3aa55 100644 --- a/packages/webdriver-utils/src/metadata/mobileMetaData.js +++ b/packages/webdriver-utils/src/metadata/mobileMetaData.js @@ -27,7 +27,7 @@ export default class MobileMetaData { if (bsVersion?.length > 0) { return bsVersion[0]; } - return this.capabilities.version.split('.')[0]; + return this.capabilities?.version?.split('.')[0]; } osName() { diff --git a/packages/webdriver-utils/test/providers/genericProvider.test.js b/packages/webdriver-utils/test/providers/genericProvider.test.js index a88ddd3c8..773eef32c 100644 --- a/packages/webdriver-utils/test/providers/genericProvider.test.js +++ b/packages/webdriver-utils/test/providers/genericProvider.test.js @@ -469,17 +469,12 @@ describe('GenericProvider', () => { it('should return 0,0 for unmatched device name', async () => { await provider.createDriver(); let mockResponseObject = { - 'iPhone 13 Pro-14': { - safari: { - header: 141, - footer: 399 - } - } + 'iPhone 13 Pro-14': {} }; spyOn(Cache, 'withCache').and.returnValue( Promise.resolve(mockResponseObject) ); - const [header, footer] = await provider.getHeaderFooter(); + const [header, footer] = await provider.getHeaderFooter('iPhone 13 Pro', '14', 'safari'); expect(header).toEqual(0); expect(footer).toEqual(0); });