-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
percy snapshot should offer a dump option for debugging #1327
Comments
Hey @mbr-sn This is a very nice suggestion! currently, you may intercept these requests and store them till we have support for this. cli/packages/client/src/client.js Lines 294 to 345 in eb03b7e
cli/packages/client/src/client.js Lines 265 to 291 in eb03b7e
|
Since there can be multiple items in the snapshot.yml, the --dump option should just take the "name:" value of each item, and create a subfolder underneath the main dump directory, and in that folder store the DOM file and all related assets. :-) |
One of the challenges we are currently facing with dynamic (JS-based) changes to our page DOM, is that we don't really know exactly what kind of DOM state is frozen and uploaded to percy.io
Even the debug log does not provide this.
So we need a lot of trial-and-error playing around with timeout values, beforeSnapshot Javascripts hacks, etc.
Suggested new feature for percy snapshot command:
What would be really helpful in that case, would be a --dump directory option for the percy snapshot command.
This option should cause percy to write a copy of the frozen DOM tree as a file to that folder, also including all the assets it identified during asset discovery phase. In other words a full 1-1 as-is copy of everything that percy uploads to the cloud for the screenshots to be taken.
The text was updated successfully, but these errors were encountered: