Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for IGNORE_TIMEOUT_ERROR env #1805

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Adding support for IGNORE_TIMEOUT_ERROR env #1805

merged 2 commits into from
Dec 2, 2024

Conversation

Amit3200
Copy link
Contributor

@Amit3200 Amit3200 commented Nov 29, 2024 •
edited
Loading

  • Adding support for PERCY_IGNORE_TIMEOUT_ERROR env
  • This will ensure that if above env is set to true, we would regardless upload snapshots instead of failing them.

@Amit3200 Amit3200 requested a review from a team as a code owner November 29, 2024 18:56
ninadbstack
ninadbstack reviewed Nov 30, 2024
View reviewed changes
packages/core/src/network.js
msg += this.logNetworkRequests(filter);
}

if (process.env.PERCY_IGNORE_TIMEOUT_ERROR === 'true') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change only ignores network idle timeouts. Not page load. That you need to handle in page.ja

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

page.js calls the function _throwTimeoutError to throw the error so if its set that is also handled.

@rishigupta1599 rishigupta1599 merged commit 2e25463 into master Dec 2, 2024
36 checks passed
@rishigupta1599 rishigupta1599 deleted the feat/ignore-network-timeouts branch December 2, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninadbstack ninadbstack ninadbstack left review comments

@rishigupta1599 rishigupta1599 rishigupta1599 approved these changes

@prklm10 prklm10 prklm10 approved these changes

@shantanuk-browserstack shantanuk-browserstack Awaiting requested review from shantanuk-browserstack shantanuk-browserstack is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Amit3200 @prklm10 @ninadbstack @rishigupta1599