Skip to content

Commit

Permalink
fix: Pin @oclif/command to 1.5.16 (#319)
Browse files Browse the repository at this point in the history
* fix: Pin `@oclif/command` to `1.5.16`

1.5.17 introduces type changes that breaks our build (even though the code is
fine and the same):
oclif/command@v1.5.16...v1.5.17#diff-53649f4ba3d51e10eff913927cc17e0c

Until we can unbreak TS, we'll stick to this version.

* Add package building to circle workflow

This would have caught the issue with dependabot upgrading oclif command
  • Loading branch information
Robdel12 authored Aug 6, 2019
1 parent 7fb2f81 commit 2ba2698
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 27 deletions.
3 changes: 3 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ jobs:
- run:
name: Help command
command: ./bin/run --help
- run:
name: Build package
command: npm run build
- run:
name: Unit tests
command: |
Expand Down
30 changes: 4 additions & 26 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"bugs": "https://github.com/percy/percy-agent/issues",
"dependencies": {
"@oclif/command": "1.5.18",
"@oclif/command": "1.5.16",
"@oclif/config": "^1",
"@oclif/plugin-help": "^2",
"@oclif/plugin-not-found": "^1.2",
Expand Down

0 comments on commit 2ba2698

Please sign in to comment.