fix: Capture resources even when Puppeteer tab times out (#510)

This splits the try/catches up so we can still capture the discovered resourses even if the `goto` times out.
percy · May 18, 2020 · 8a39366 · 8a39366
1 parent 06dc067
commit 8a39366
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/services/asset-discovery-service.ts b/src/services/asset-discovery-service.ts
@@ -296,7 +296,12 @@ export class AssetDiscoveryService extends PercyClientService {
       profile('--> assetDiscoveryService.waitForNetworkIdle')
       await waitForNetworkIdle(page, this.configuration['network-idle-timeout'])
       profile('--> assetDiscoveryService.waitForNetworkIdle')
+    } catch (error) {
+      logger.error(addLogDate(`${error.name} ${error.message}`))
+      logger.debug(addLogDate(error))
+    }
 
+    try {
       profile('--> assetDiscoveryServer.waitForResourceProcessing')
       maybeResources = await Promise.all(maybeResourcePromises)
       profile('--> assetDiscoveryServer.waitForResourceProcessing')