fix: Disable HTTPS errors for asset discovery #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fail to snapshot with Percy (but the test suite will pass). We will need to make sure we review any diffs that arise.
This is so the asset discovery service doesn't fail to capture assets for snapshots that are done on invalid HTTPS sites. Without this the assets would be missing from the snapshots (as seen in the previous commits percy build).
djones
pushed a commit
that referenced
this pull request
May 14, 2019
## [0.4.8](v0.4.7...v0.4.8) (2019-05-14) ### Bug Fixes * Disable HTTPS errors for asset discovery ([#199](#199)) ([e19c91e](e19c91e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This is so the asset discovery service doesn't fail to capture assets for snapshots that are done on invalid HTTPS sites. Without this the assets would be missing from the snapshots (as seen in this PRs first commit Percy build).
The test that's included here will be missing styles if the snapshot fails -- but the test suite will not fail. The Percy build will have diffs though.