fix: Always apply form elements value property as an attribute #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason for us to check to see if the value attribute exists on a DOM node already. This was probably a check to prevent us from modifying the customers DOM when we were mutating in place. Now we're only modifying the clone, so it's safe to _always_ set the attribute from the DOM elements property.
|
@blake-newman would you be able to confirm this fixes your use case? |
|
@djones yes I can no problem, can't right now as our ci infrastructure turns off during OOO hours. So will have report back to you for your morning |
|
Can confirm this works 👍 |
djones
pushed a commit
that referenced
this pull request
Jun 6, 2019
## [0.5.3](v0.5.2...v0.5.3) (2019-06-06) ### Bug Fixes * Always apply form elements value property as an attribute ([#227](#227)) ([8bcc318](8bcc318))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Previously, if the
valueattribute was present in the DOM, we didn't serialize the elementsvalueproperty to the attribute. There's no reason for us to make this check. it's 100% safe for us to always apply the property value as an attribute on the DOM node.I also noticed there's a bug with the switch where we didn't have a
breakontextareas, so we were always adding an invalidvalueattribute.