feat: Improved large resource handling #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones
commented
Jun 6, 2019
| // truncate domSnapshot for the logs if it's very large | ||
| let domSnapshotLog = request.body.domSnapshot | ||
| if (domSnapshotLog.length > Constants.MAX_LOG_LENGTH) { | ||
| domSnapshotLog = domSnapshotLog.substring(0, Constants.MAX_LOG_LENGTH) |
There was a problem hiding this comment.
I think you'll like this one @Robdel12. We'll no longer spit out huge logs that are 99% the domSnapshot content.
djones
force-pushed
the
david-jones/skip-large-resources
branch
from
9301dbb to
45507a7
Compare
djones
changed the title
fotinakis
reviewed
Jun 6, 2019
| @@ -55,6 +56,13 @@ export default class ResponseService extends PercyClientService { | |||
| return | |||
| } | |||
|
|
|||
| const responseBodySize = (await response.buffer()).length | |||
| if (responseBodySize > Constants.MAX_FILE_SIZE_BYTES) { | |||
There was a problem hiding this comment.
Per discussion, let's reorganize this to stat the local file copy afterward, instead of reading the buffer and checking it here before writing the local copy (ie. optimize for the 99% case of not skipping, and use stat because it's fast and avoids the double buffer read)
djones
pushed a commit
that referenced
this pull request
Jun 6, 2019
# [0.7.0](v0.6.0...v0.7.0) (2019-06-06) ### Features * Improved large resource handling ([#243](#243)) ([4681425](4681425))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
You'll see logs like this in the integration test run:
That is excepted behavior. Graceful handling of a large DOM and warning you about it.
This PR also drops large resources gracefully and early. If you have
LOG_LEVEL=debugset you will see in the logs something like this: