feat: Add configuration option to enable javascript #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilsman
commented
Sep 3, 2019
| enableJavaScript: request.body.enableJavaScript, | ||
| enableJavaScript: request.body.enableJavaScript != null | ||
| ? request.body.enableJavaScript | ||
| : configuration.snapshot['enable-javascript'], |
There was a problem hiding this comment.
The nullish operator would've been perfect here:
request.body.enableJavaScript ?? configuration.snapshot['enable-javascript']
Robdel12
approved these changes
Sep 3, 2019
|
Oh, also don't forget to update the SDK config docs |
wwilsman
changed the title
|
I don't think the docs need an update since this is a "hidden" option. We don't document enableJavaScript anywhere else, do we? If we wanted to, I'd say we should update all docs across the board |
djones
pushed a commit
that referenced
this pull request
Sep 3, 2019
# [0.11.0](v0.10.1...v0.11.0) (2019-09-03) ### Features * Add configuration option to enable javascript ([#341](#341)) ([fb05050](fb05050))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enabling JavaScript must be done on a per-snapshot basis and in rare cases where the user needs to enable it for every snapshot, it becomes tedious to add it to every snapshot call.
Approach
Add an
enable-javascriptoption to the configuration file to enable setting this option for all snapshots in a single setting.I know we don't recommend setting this option normally, however if needed it can be a pain to set this for every single snapshot.