Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIGINT / Ctrl+C on percy start finalizes build, then throws UnhandledPromiseRejectionWarning #408

Closed
danielrozenberg opened this issue Oct 30, 2019 · 2 comments
Closed

SIGINT / Ctrl+C on percy start finalizes build, then throws UnhandledPromiseRejectionWarning #408

danielrozenberg opened this issue Oct 30, 2019 · 2 comments

Comments

@danielrozenberg
Copy link

Our CI process spawns off a new percy start process, performs all the tests and snapshots, then sends a SIGINT signal to the agent process to finalize it.

Starting in v0.19.2, the SIGINT signal throws the above mentioned warning, although it still finalizes the build so things still work as expected. I tried reproducing it in versions 0.19.5 through 0.19.1 and the error was thrown in all of them except 0.19.1:

Travis logs:

*the PR was later force-pushed by renovate-bot to v0.19.3, but the Travis logs for v0.19.2 are still there
@Robdel12 Robdel12 mentioned this issue Oct 30, 2019
Merged
@Robdel12
Copy link
Contributor

Closed with #409 -- thanks for the report!

@danielrozenberg
Copy link
Author

Confirmed fixed for us: https://travis-ci.org/ampproject/amphtml/jobs/605568560#L2381-L2382
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielrozenberg @Robdel12