feat: Introduce asset discovery response caching behind flag #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the caching layer real thin, since its an optimization
Up next is to test
wwilsman
suggested changes
Nov 8, 2019
wwilsman
approved these changes
Nov 8, 2019
djones
pushed a commit
that referenced
this pull request
Nov 8, 2019
# [0.20.0](v0.19.7...v0.20.0) (2019-11-08) ### Features * Introduce asset discovery response caching behind flag ([#419](#419)) ([7d7dd52](7d7dd52))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Sometimes the Percy Agent asset discovery service can overload a customers test server, which means sometimes snapshots are missing assets. Right now, we hit their applications test server for each asset at each width.
Off by default, this PR introduces a way to enable response caching for asset discovery. This is so our asset discovery service only will hit their applications test server for a given asset once (if we get a 200 response). In theory, it should reduce the number of SDK related missing assets (most commonly seen in rails apps)