fix: don't log success on error #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It pains me to push this up without a failing test 😢
Adds a test to verify that the error is logged to stderr and that the finalize log is not present due to the error
timhaines
reviewed
Dec 11, 2019
| await this.percyClient.finalizeBuild(this.buildId) | ||
| this.logEvent('finalized') | ||
| } catch (err) { | ||
| logError(err) |
There was a problem hiding this comment.
Can we add some context here.. Perhaps a log line above this logError that says Error during build finalize: or something similar.
djones
pushed a commit
that referenced
this pull request
Dec 11, 2019
## [0.20.4](v0.20.3...v0.20.4) (2019-12-11) ### Bug Fixes * don't log success on error ([#435](#435)) ([84ac23f](84ac23f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Even if the finalize request fails, we currently print a
finalized buildmessage (which is not true)Approach
@Robdel12 did the fix, I added a test and sent the error to stderr rather than stdout.
Previously, we were
catching a promise and then logging "successfully." Since the promise thinks the error is "handled" it allows execution to continue. Movingcatchto be afterthenrather than before will correctly log on a successful response only. Also, rather than mixingasync/awaitandthen/catch, this change strictly sticks toasync/await(and uses atry/catchblock instead of promise methods).