fix: Skip requests in asset discovery that will never be saved #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't bother waiting for a request to finish during asset discovery if we're not going to save it
Somehow this worked in node 10?
wwilsman
approved these changes
Jan 16, 2020
delete-merged-branch
bot
deleted the
rd/skip-requests-that-wont-be-saved
branch
djones
pushed a commit
that referenced
this pull request
Jan 16, 2020
## [0.20.11](v0.20.10...v0.20.11) (2020-01-16) ### Bug Fixes * Skip requests in asset discovery that will never be saved ([#457](#457)) ([ce36cf2](ce36cf2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This PR makes it so we abort any request that we won't save. This will prevent asset discovery from failing on requests that never resolve (and don't matter to us)