Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues upgrading to Percy Storybook v4 #565

Closed
jeffchew opened this issue May 17, 2022 · 0 comments
Closed

Issues upgrading to Percy Storybook v4 #565

jeffchew opened this issue May 17, 2022 · 0 comments

Comments

@jeffchew
Copy link

The problem

We have been having issues upgrading @percy/storybook from v3 to v4. We have made the suggestion of removing any ad service calls (by removing them entirely) but still seems to be an issue. The end result is that most snapshots go missing. This is observed in both our React components and Web Components versions of Storybook:

PR opened:
carbon-design-system/carbon-for-ibm-dotcom#8128

React Percy latest result:
https://percy.io/538fc19a/Carbon-for-IBM.com-React/builds/18147514?utm_campaign=538fc19a&utm_content=Carbon-for-IBM.com-React&utm_source=github_status_public

image

Web Components Percy latest result:
https://percy.io/538fc19a/Carbon-for-IBM.com-Web-Components/builds/18148038?utm_campaign=538fc19a&utm_content=Carbon-for-IBM.com-Web-Components&utm_source=github_status_public

image

Environment

  • Node version: 14
  • @percy/cli version: 1.2.0
  • Version of Percy SDK you’re using: 4.2.0
  • If needed, a build or snapshot ID: see above
  • OS version: Ubuntu 20
  • Type of shell command-line [interface]: Linux (Jenkins on Kubernetes)
  • Storybook v5 (we are in the process of migrating to v6)

Details

When digging into the logs, it appears that JS artifacts themselves (produced by Storybook) are getting blocked, an example of what we're seeing:

image

image

Debug logs

Attached:
Deploy Preview build log 20220517.txt

Code to reproduce issue

You can probably best see using the fork:
carbon-design-system/carbon-for-ibm-dotcom#8128

Steps to build:

  1. yarn install
  2. yarn build
  3. cd packages/react
  4. yarn build-storybook
  5. yarn visual-snapshot
@percy percy locked and limited conversation to collaborators May 17, 2022
@Robdel12 Robdel12 converted this issue into discussion #566 May 17, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant