Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidify when to make a new component. #585

Open
sniyaz opened this issue Sep 25, 2020 · 0 comments
Open

Solidify when to make a new component. #585

sniyaz opened this issue Sep 25, 2020 · 0 comments
Assignees
Milestone

Comments

@sniyaz
Copy link

sniyaz commented Sep 25, 2020

During the review of #567, the issue arose of when exactly we should add new components to AIKIDO. The logic in this PR is that a new component should be added when either/or:

  1. The amount of code in this component has grown large enough that splitting it off makes sense.
  2. The dependencies involved would mean that a large component (with lots of critical functionality) would fail to build if certain optional dependencies were not installed correctly.

We should debate and solidify these guidelines, then add them to our code guidelines.

@sniyaz sniyaz added this to the Aikido 0.5.0 milestone Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants