Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose on-chain WithdrawalException event on Erdstall Client API #116

Open
sebastianst opened this issue Nov 8, 2021 · 0 comments
Open
Labels

Comments

@sebastianst
Copy link
Contributor

If an individual asset's withdrawal throws during a withdraw on-chain call, the Erdstall smart contract doesn't revert the whole transaction, but just throws a WithdrawalException for this particular asset. This is a safety mechanism to avoid a single token from reverting other token withdrawals indefinitely.

This event still needs to be exposed on the Erdstall client API.

When testing this, the RevertToken from can be used to trigger a revert during a withdrawal.

@RmbRT RmbRT added the prio label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants