Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .equals(...) methods to Erdstall base types #26

Open
ndzik opened this issue Jul 23, 2021 · 0 comments
Open

Add .equals(...) methods to Erdstall base types #26

ndzik opened this issue Jul 23, 2021 · 0 comments

Comments

@ndzik
Copy link
Contributor

ndzik commented Jul 23, 2021

To aid the intuition of developers using our SDK we should strive to use a familiar API for our types.

{Asset|Assets} includes a cmp(...) method, while types like Address and BigInteger implement an equals method.

I propose to add the equals method where possible. Currently that would be in {Asset|Assets}.

See also here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ndzik