Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create type SignedTradeOffer and let TradeOffer.sign return it #98

Open
sebastianst opened this issue Oct 13, 2021 · 0 comments · May be fixed by #130
Open

Create type SignedTradeOffer and let TradeOffer.sign return it #98

sebastianst opened this issue Oct 13, 2021 · 0 comments · May be fixed by #130
Labels
enhancement New feature or request

Comments

@sebastianst
Copy link
Contributor

sebastianst commented Oct 13, 2021 •
edited
Loading

Field sig of SignedTradeOffer should be a required property (is optional in TradeOffer).

If possible, creation of a copy should be avoided.

This can be used to improve the type safety of trade offer handling in NERD's MarketplaceServer.
@sebastianst sebastianst added the enhancement New feature or request label Oct 13, 2021
@Ruben-Kruepper Ruben-Kruepper linked a pull request Dec 6, 2021 that will close this issue
transactions/trade: Add SignedTradeOffer Closes #98 #130
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

transactions/trade: Add SignedTradeOffer Closes #98 perun-network/erdstall-ts-sdk
1 participant
@sebastianst