Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search index missing New-PesterConfiguration codeblock #280

Closed
2 tasks done
fflaten opened this issue Sep 2, 2023 · 8 comments · Fixed by #316
Closed
2 tasks done

Search index missing New-PesterConfiguration codeblock #280

fflaten opened this issue Sep 2, 2023 · 8 comments · Fixed by #316
Labels
bug Something isn't working

Comments

@fflaten
Copy link
Collaborator

fflaten commented Sep 2, 2023

Checklist

  • Issue has a meaningful title
  • I have searched the existing issues. See issues

Link to page

https://pester.dev/docs/commands/New-PesterConfiguration

What is the issue?

Searching for SkipRemainingOnFailure returns no result even though it's documented in the New-PesterConfiguration help. I assume it's because codeblocks are excluded from indexing.

Suggested fix?

Is it possible to include codeblock for that specific page?
Or should we focus on documenting all the options as part of other pages. Ex in this case as a section @ https://pester.dev/docs/usage/skip ?

@bravo-kernel
Copy link
Collaborator

It looks like this Algolia thread contains a similar question. https://discourse.algolia.com/t/experience-and-advice-for-dealing-with-indexing-of-code-in-software-documentation/8307/3

It also mentions a specific tag that will help the DocSearch crawler to know what are the part important but I cannot seem to find an example. To me, that sentence reads as if it would be possible to include the codeblock only for that specific page.

@fflaten fflaten added the bug Something isn't working label Jun 9, 2024
@fflaten
Copy link
Collaborator Author

fflaten commented Jun 9, 2024

I'm considering generating this directly to markdown as a section in docs/Configuration maybe. Just like we do now in New-PesterConfiguration comment help.

Will fix this, have improved formatting and ToC for easier navigation.

Maybe also extract the generated help from New-PesterConfiguration to about_PesterConfiguration.txt in the module.

@fflaten
Copy link
Collaborator Author

fflaten commented Jun 13, 2024

Made a PoC. Thoughts?

List:
image

Table with FQON (fully qualified option name 🤓):
image

Table with option name:
image

@bravo-kernel
Copy link
Collaborator

Awesome, the FQON table is the most readable one for me. Super clear.

@fflaten
Copy link
Collaborator Author

fflaten commented Jun 17, 2024

Thanks. I'm undecided between FQON table and list. Table is bad on phone in portrait mode, while list use a lot of vertical space.

@bravo-kernel
Copy link
Collaborator

bravo-kernel commented Jun 18, 2024

How does the Tanstack table look bad on mobile? I use it myself and once I accepted the horizontal scrolbar it looks fine for me.

@fflaten
Copy link
Collaborator Author

fflaten commented Jun 18, 2024

How does the Tanstack table look bad on mobile? I use it myself and once I accepted the horizontal scrolbar it looks fine for me.

When I wrote it they overflowed and broke the layout. Fixed in 68bffbe with same wrapper used on tanstack tables earlier. 👷‍♂️ 👍

Personally not a fan of horizontal scrolling though.

@bravo-kernel
Copy link
Collaborator

Yes, the overflow is a thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants