Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashin removes # when hashes were generated with pip-compile #124

Closed
alaamub opened this issue Oct 6, 2021 · 3 comments · Fixed by #125
Closed

hashin removes # when hashes were generated with pip-compile #124

alaamub opened this issue Oct 6, 2021 · 3 comments · Fixed by #125

Comments

@alaamub
Copy link

alaamub commented Oct 6, 2021

Looks like hashin removes # when hashes were generated with pip-compile originally. Example

-requests==2.25.1 \
-    --hash=sha256:27973dd4a904a4f13b263a19c866c13b92a39ed1c964655f025f3f8d3d75b804 \
-    --hash=sha256:c210084e36a42ae6b9219e00e48287def368a26d03a048ddad7bfee44f75871e
-    # via -r project/requirements.in
+requests==2.22.0 \
+    --hash=sha256:11e007a8a2aa0323f5a921e9e6a2d7e4e67d9877e85773fba9ba6419025cbeb4 \
+    --hash=sha256:9cf5292fcd0f598c671cfc1e0d7d1a7f13bb8085e9a590f48c010551dc6c4b31
@MarkusH
Copy link
Contributor

MarkusH commented Oct 7, 2021

I've opened a pull request to tackle this: #125

@alaamub
Copy link
Author

alaamub commented Oct 7, 2021

Awesome, Thank you!

@peterbe
Copy link
Owner

peterbe commented Jan 3, 2022

@alaamub Would you mind helping @MarkusH by checking out his branch and running python hashin.py ... against a file that had comments. And can you also help by asserting that the correct indentation of the now-kept comments are intact?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants