Make puppeteer peerDependency

[stereobooster]

If I use minimalcss in react-snap it will download two copies of puppeteer. If we make minimalcss-core without CLI and with peerDependency puppeteer and minimalcss with CLI and with puppeteer+minimalcss-core dependency I will be able to use minimalcss-core in react-snap with one copy of puppeteer

Todo this we probably want to use monorepo, see https://github.com/lerna/lerna and https://yarnpkg.com/blog/2017/08/02/introducing-workspaces/

[peterbe]

I have only read about workspaces but if it means we can have one package.json for the cli and one package.json for the "core", that would be awesome.
But what does it mean in terms of npmjs.com?
I do like the idea of splitting the code into smaller parts but I'm quite pessimistic about breaking up the repo.

[stereobooster]

I have only read about workspaces but if it means we can have one package.json for the cli and one package.json for the "core", that would be awesome.

Yes.

But what does it mean in terms of npmjs.com?

It means you will have two separate npm packages, but they will live in one repo for development convenience.

I do like the idea of splitting the code into smaller parts but I'm quite pessimistic about breaking up the repo.

Create-react-app does this, for example.

[peterbe]

Neat! I like this.
Do I need to run jest inside each directory? (not a problem)

[stereobooster]

Do I need to run jest inside each directory?

Yes, but there will be one top level package.json you can create one task which will run all tests in subdirectories