chore(linter): enable no-unused-vars error

This makes it so that the linter will error
out when there are unused variables.
This is more important than it looks because unused imports can contribute
a lot of overhead to the build artifact sizes.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>

.eslintrc.js

@@ -15,13 +15,10 @@ module.exports = {
     "no-prototype-builtins": "error",
     "@typescript-eslint/no-var-requires": "warn",
     "no-dupe-class-members": "off",
-    "no-unused-vars": [
-      "warn",
-      {
-        vars: "all",
-        args: "after-used",
-        ignoreRestSiblings: false,
-      },
+    "no-unused-vars": "off",
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      { ignoreRestSiblings: true },
     ],
     indent: ["off"],
     semi: ["error", "always"],

examples/cactus-example-supply-chain-backend/src/main/typescript/supply-chain-app.ts

@@ -32,7 +32,6 @@ import {
   PluginLedgerConnectorQuorum,
   Web3SigningCredentialType,
   DefaultApi as QuorumApi,
-  EthContractInvocationType,
 } from "@hyperledger/cactus-plugin-ledger-connector-quorum";
 
 import {
@@ -41,10 +40,7 @@ import {
 } from "@hyperledger/cactus-plugin-ledger-connector-besu";
 
 import { SupplyChainAppDummyInfrastructure } from "./infrastructure/supply-chain-app-dummy-infrastructure";
-import {
-  BambooHarvest,
-  SupplyChainCactusPlugin,
-} from "@hyperledger/cactus-example-supply-chain-business-logic-plugin";
+import { SupplyChainCactusPlugin } from "@hyperledger/cactus-example-supply-chain-business-logic-plugin";
 
 export interface ISupplyChainAppOptions {
   logLevel?: LogLevelDesc;

examples/cactus-example-supply-chain-business-logic-plugin/src/main/typescript/business-logic-plugin/web-services/insert-bamboo-harvest-endpoint.ts

@@ -1,4 +1,4 @@
-import { Express, Request, Response, NextFunction } from "express";
+import { Express, Request, Response } from "express";
 
 import {
   Logger,
@@ -39,7 +39,7 @@ export class InsertBambooHarvestEndpoint implements IWebServiceEndpoint {
 
   private readonly log: Logger;
 
-  public get className() {
+  public get className(): string {
     return InsertBambooHarvestEndpoint.CLASS_NAME;
   }
 
@@ -76,11 +76,7 @@ export class InsertBambooHarvestEndpoint implements IWebServiceEndpoint {
     return this.handleRequest.bind(this);
   }
 
-  async handleRequest(
-    req: Request,
-    res: Response,
-    next: NextFunction,
-  ): Promise<void> {
+  async handleRequest(req: Request, res: Response): Promise<void> {
     const tag = `${this.getVerbLowerCase().toUpperCase()} ${this.getPath()}`;
     try {
       const { bambooHarvest } = req.body as InsertBambooHarvestRequest;

examples/cactus-example-supply-chain-business-logic-plugin/src/main/typescript/business-logic-plugin/web-services/insert-bookshelf-endpoint.ts

@@ -1,4 +1,4 @@
-import { Express, Request, Response, NextFunction } from "express";
+import { Express, Request, Response } from "express";
 
 import {
   Logger,
@@ -39,7 +39,7 @@ export class InsertBookshelfEndpoint implements IWebServiceEndpoint {
 
   private readonly log: Logger;
 
-  public get className() {
+  public get className(): string {
     return InsertBookshelfEndpoint.CLASS_NAME;
   }
 
@@ -76,11 +76,7 @@ export class InsertBookshelfEndpoint implements IWebServiceEndpoint {
     return this.handleRequest.bind(this);
   }
 
-  async handleRequest(
-    req: Request,
-    res: Response,
-    next: NextFunction,
-  ): Promise<void> {
+  async handleRequest(req: Request, res: Response): Promise<void> {
     const tag = `${this.getVerbLowerCase().toUpperCase()} ${this.getPath()}`;
     try {
       const { bookshelf } = req.body as InsertBookshelfRequest;

examples/cactus-example-supply-chain-business-logic-plugin/src/main/typescript/business-logic-plugin/web-services/list-bamboo-harvest-endpoint.ts

@@ -1,4 +1,4 @@
-import { Express, Request, Response, NextFunction } from "express";
+import { Express, Request, Response } from "express";
 
 import {
   Logger,
@@ -75,11 +75,7 @@ export class ListBambooHarvestEndpoint implements IWebServiceEndpoint {
     return this.handleRequest.bind(this);
   }
 
-  async handleRequest(
-    req: Request,
-    res: Response,
-    next: NextFunction,
-  ): Promise<void> {
+  async handleRequest(req: Request, res: Response): Promise<void> {
     const tag = `${this.getVerbLowerCase().toUpperCase()} ${this.getPath()}`;
     try {
       this.log.debug(`${tag}`);

examples/cactus-example-supply-chain-business-logic-plugin/src/main/typescript/business-logic-plugin/web-services/list-bookshelf-endpoint.ts

@@ -1,4 +1,4 @@
-import { Express, Request, Response, NextFunction } from "express";
+import { Express, Request, Response } from "express";
 
 import {
   Logger,
@@ -38,7 +38,7 @@ export class ListBookshelfEndpoint implements IWebServiceEndpoint {
 
   private readonly log: Logger;
 
-  public get className() {
+  public get className(): string {
     return ListBookshelfEndpoint.CLASS_NAME;
   }
 
@@ -75,11 +75,7 @@ export class ListBookshelfEndpoint implements IWebServiceEndpoint {
     return this.handleRequest.bind(this);
   }
 
-  async handleRequest(
-    req: Request,
-    res: Response,
-    next: NextFunction,
-  ): Promise<void> {
+  async handleRequest(req: Request, res: Response): Promise<void> {
     const tag = `${this.getVerbLowerCase().toUpperCase()} ${this.getPath()}`;
     try {
       this.log.debug(`${tag}`);

examples/cactus-example-supply-chain-frontend/src/app/app.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from "@angular/core";
+import { Component } from "@angular/core";
 
 import { Platform } from "@ionic/angular";
 import { SplashScreen } from "@ionic-native/splash-screen/ngx";

examples/cactus-example-supply-chain-frontend/src/app/bamboo-harvest/bamboo-harvest-detail/bamboo-harvest-detail.page.ts

@@ -5,10 +5,7 @@ import { FormGroup, FormBuilder, Validators } from "@angular/forms";
 import { ModalController } from "@ionic/angular";
 
 import { ApiClient } from "@hyperledger/cactus-api-client";
-import {
-  BambooHarvest,
-  DefaultApi as SupplyChainApi,
-} from "@hyperledger/cactus-example-supply-chain-business-logic-plugin";
+import { BambooHarvest } from "@hyperledger/cactus-example-supply-chain-business-logic-plugin";
 
 import { QUORUM_DEMO_LEDGER_ID } from "../../../constants";
 import { Logger, LoggerProvider } from "@hyperledger/cactus-common";
@@ -55,13 +52,13 @@ export class BambooHarvestDetailPage implements OnInit {
     });
   }
 
-  onClickFormSubmit(value: any) {
+  public onClickFormSubmit(value: any): void {
     this.log.debug("form submitted", value);
     this.bambooHarvest = value;
     this.modalController.dismiss(this.bambooHarvest);
   }
 
-  onClickBtnCancel() {
+  public onClickBtnCancel(): void {
     this.log.debug("form submission cancelled by user");
     this.modalController.dismiss();
   }

examples/cactus-example-supply-chain-frontend/src/app/bamboo-harvest/bamboo-harvest-list/bamboo-harvest-list.page.ts

@@ -1,7 +1,5 @@
 import { Component, Inject, OnInit } from "@angular/core";
 
-import { v4 as uuidv4 } from "uuid";
-
 import { Logger, LoggerProvider } from "@hyperledger/cactus-common";
 import { ApiClient } from "@hyperledger/cactus-api-client";
 import {

packages/cactus-cmd-api-server/src/main/typescript/cmd/cactus-api.ts

@@ -27,7 +27,7 @@ const main = async () => {
   }
 };
 
-export async function launchApp(cliOpts?: any): Promise<void> {
+export async function launchApp(): Promise<void> {
   try {
     await main();
     log.info(`Cactus API server launched OK `);

packages/cactus-cmd-api-server/src/test/typescript/integration/remote-plugin-imports.test.ts

@@ -1,8 +1,6 @@
 import test, { Test } from "tape-promise/tape";
 import { v4 as uuidv4 } from "uuid";
 
-import { LogLevelDesc } from "@hyperledger/cactus-common";
-
 import { ApiServer, ConfigService } from "../../../main/typescript/public-api";
 
 import {

packages/cactus-cmd-api-server/src/test/typescript/unit/config/self-signed-certificate-generator/certificates-work-for-mutual-tls-test.ts

@@ -79,6 +79,7 @@ tap.test("works with HTTPS NodeJS module", async (assert: any) => {
       ),
     );
 
+    aServer.once("tlsClientError", (err: Error) => reject(err));
     aServer.once("listening", () => resolve(aServer));
     aServer.listen(0, "localhost");
     assert.tearDown(() => aServer.close());

packages/cactus-cockpit/src/app/app.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit, Inject } from "@angular/core";
+import { Component, Inject } from "@angular/core";
 
 import { Platform } from "@ionic/angular";
 import { SplashScreen } from "@ionic-native/splash-screen/ngx";

packages/cactus-cockpit/src/app/app.module.ts

@@ -1,7 +1,6 @@
 import "@angular/compiler";
-import { NgModule, APP_INITIALIZER, InjectionToken } from "@angular/core";
+import { NgModule } from "@angular/core";
 
-import { HttpClientModule } from "@angular/common/http";
 import { BrowserModule } from "@angular/platform-browser";
 import { RouteReuseStrategy } from "@angular/router";
 

packages/cactus-common/src/main/typescript/logging/logger.ts

@@ -1,8 +1,4 @@
-import libLogLevel, {
-  Logger as LogLevelLogger,
-  levels,
-  LogLevelDesc,
-} from "loglevel";
+import libLogLevel, { Logger as LogLevelLogger, LogLevelDesc } from "loglevel";
 import prefix from "loglevel-plugin-prefix";
 
 prefix.reg(libLogLevel);
@@ -46,7 +42,7 @@ export class Logger {
     this.backend.setLevel(logLevel);
   }
 
-  public async shutdown(gracePeriodMillis = 60000): Promise<void> {
+  public async shutdown(): Promise<void> {
     this.backend.info("Shut down logger OK.");
   }
 

packages/cactus-common/src/test/typescript/unit/js-object-signer.test.ts

@@ -117,8 +117,6 @@ test("Circular JSON Test", async (assert: Test) => {
   };
   const jsObjectSigner = new JsObjectSigner(jsObjectSignerOptions);
 
-  const date: Date = new Date();
-
   const obj: any = { a: "foo" };
   obj.b = obj;
 
@@ -209,8 +207,7 @@ test("Test missing required constructor field", async (assert: Test) => {
     const jsObjectSignerOptions: IJsObjectSignerOptions = {
       privateKey: undefined,
     };
-
-    const jsObjectSigner = new JsObjectSigner(jsObjectSignerOptions);
+    new JsObjectSigner(jsObjectSignerOptions);
   } catch (e) {
     assert.equal(e.message, "JsObjectSigner#ctor options.privateKey falsy.");
   }

packages/cactus-core-api/src/main/typescript/plugin/keychain/i-plugin-keychain.ts

@@ -19,5 +19,5 @@ export interface IPluginKeychain extends ICactusPlugin {
   has(key: string): Promise<boolean>;
   get<T>(key: string): Promise<T>;
   set<T>(key: string, value: T): Promise<void>;
-  delete<T>(key: string): Promise<void>;
+  delete(key: string): Promise<void>;
 }

packages/cactus-plugin-consortium-manual/src/main/typescript/consortium/get-consortium-jws-endpoint-v1.ts

@@ -1,5 +1,4 @@
-import { Express, Request, Response, NextFunction } from "express";
-import { AxiosResponse } from "axios";
+import { Express, Request, Response } from "express";
 
 import {
   IWebServiceEndpoint,
@@ -11,7 +10,6 @@ import {
 import {
   Configuration,
   DefaultApi,
-  GetNodeJwsResponse,
 } from "../generated/openapi/typescript-axios";
 
 import {
@@ -80,11 +78,7 @@ export class GetConsortiumEndpointV1 implements IWebServiceEndpoint {
     return this;
   }
 
-  async handleRequest(
-    req: Request,
-    res: Response,
-    next: NextFunction,
-  ): Promise<void> {
+  async handleRequest(req: Request, res: Response): Promise<void> {
     const fnTag = "GetConsortiumJwsEndpointV1#handleRequest()";
     this.log.debug(`GET ${this.getPath()}`);
 

packages/cactus-plugin-consortium-manual/src/main/typescript/consortium/get-node-jws-endpoint-v1.ts

@@ -1,5 +1,5 @@
 import uuid from "uuid";
-import { Express, Request, Response, NextFunction } from "express";
+import { Express, Request, Response } from "express";
 import { JWS, JWK } from "jose";
 import jsonStableStringify from "json-stable-stringify";
 
@@ -77,11 +77,7 @@ export class GetNodeJwsEndpoint implements IWebServiceEndpoint {
     return this;
   }
 
-  async handleRequest(
-    req: Request,
-    res: Response,
-    next: NextFunction,
-  ): Promise<void> {
+  async handleRequest(req: Request, res: Response): Promise<void> {
     try {
       this.log.debug(`GET ${this.getPath()}`);
 

packages/cactus-plugin-consortium-manual/src/main/typescript/plugin-consortium-manual.ts

@@ -14,11 +14,7 @@ import {
   ICactusPluginOptions,
 } from "@hyperledger/cactus-core-api";
 
-import {
-  PluginRegistry,
-  IConsortiumRepositoryOptions,
-  ConsortiumRepository,
-} from "@hyperledger/cactus-core";
+import { PluginRegistry, ConsortiumRepository } from "@hyperledger/cactus-core";
 
 import {
   Checks,
@@ -82,7 +78,7 @@ export class PluginConsortiumManual
   }
 
   public async installWebServices(
-    expressApp: any,
+    expressApp: Express,
   ): Promise<IWebServiceEndpoint[]> {
     const { log } = this;
 
@@ -113,7 +109,6 @@ export class PluginConsortiumManual
     }
 
     const { consortiumDatabase, keyPairPem } = this.options;
-    const packageName = this.getPackageName();
     const consortiumRepo = new ConsortiumRepository({
       db: consortiumDatabase,
     });