Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license question #1851

Closed
chenrui333 opened this issue Jan 17, 2021 · 9 comments · Fixed by #1853 or #1858
Closed

license question #1851

chenrui333 opened this issue Jan 17, 2021 · 9 comments · Fixed by #1853 or #1858

Comments

@chenrui333
Copy link

chenrui333 commented Jan 17, 2021

per discussion in here

Can I assume the license should be GPL-2.0-or-later for the project (as GPL-2.0 is deprecated)?

cc @dkastl @cvvergara @sanak


relates to Homebrew/homebrew-core#69231

@cvvergara
Copy link
Member

With this comment I confirm that:
Due to the fact that GPL-2.0 is deprecated we are moving to GPL-2.0-or-later

Administrative issue opened here:
pgRouting/admin#40

@dkastl
Copy link
Member

dkastl commented Jan 20, 2021

I think by making this change, we will prevent anyone using pgRouting code when their project is licensed under "GPLv3 or later". I'm not sure this is our intention and as far as I understand this would be a restriction that was not intended and exactly the reason why "GPL-2.0-or-later" sounded like the right thing.

@dkastl
Copy link
Member

dkastl commented Jan 20, 2021

Confusing ...

... because the titles of the license files read the same.
So both still exist, but looking at the URL schema they maybe have seen some clarifications.

@dkastl
Copy link
Member

dkastl commented Jan 20, 2021

So we eventually just use an outdated license text, but with the original intent to also apply to "later" versions of GPL
https://github.com/pgRouting/pgrouting/blob/master/LICENSE#L296-L299

@sanak
Copy link
Member

sanak commented Jan 21, 2021

@dkastl (CC: @cvvergara, @chenrui333)
Okay, thanks for details.
By the way, I compared spdx license site contents difference between GPL-2.0-only and GPL-2.0-or-later and there seems to be no difference about the description part which you mentioned, but the difference is just quote part.

-Copyright (C) yyyy name of author
-This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License 
-as published by the Free Software Foundation; version 2.
+<one line to give the program's name and an idea of what it does.>
+Copyright (C) <yyyy> <name of author>
+
+This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License 
+as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.

And current code search result of the quote was latter (-or-later) one, so I think that that current license is already GPL-2.0-or-later and no need to do quick license update.

@dkastl
Copy link
Member

dkastl commented Jan 21, 2021

Thanks for comparing! I also wanted to do this, and I also didn't expect much changes. Good to see that there isn't any change in the content at all. I guess this was just a change in the name (and URL) for clarification. So this isn't a change of the license on our side I would say.

@sanak
Copy link
Member

sanak commented Jan 21, 2021

@dkastl Okay, thanks for confirmation.

@chenrui333

Can I assume the license should be GPL-2.0-or-later for the project (as GPL-2.0 is deprecated)?

From the above discussion, we can say that the license is GPL-2.0-or-later already.

@chenrui333
Copy link
Author

The license body btw GPL-2.0-only and GPL-2.0-or-later are the same, the difference resides in the header declaration. It would be either applied to every license header in the source files (some projects have inconsistent licenses across the projects, like some source code are from other projects, or some code wants to be dual-licensed) or applied in the README on the project level.

With that being said, it would be preferred to add something in the README (I think this is the easiest way to add license header declaration).

Let me know if that makes sense.

@sanak
Copy link
Member

sanak commented Jan 21, 2021

@chenrui333 (CC: @dkastl @cvvergara)
Oh, yes, sure.

My original misunderstanding came from the following README.md line, so that should be updated like Most features are available under GPL v2 or later.
https://github.com/pgRouting/pgrouting#license

* Most features are available under GPLv2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants