Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw the rest of the ̶o̶w̶l̶ new ABI-handling framework #1661

Open
11 of 21 tasks
workingjubilee opened this issue Apr 17, 2024 · 2 comments
Open
11 of 21 tasks

Draw the rest of the ̶o̶w̶l̶ new ABI-handling framework #1661

workingjubilee opened this issue Apr 17, 2024 · 2 comments
Labels
bug Something isn't working E_TOO_MANY_LABELS enhancement New feature or request ffi macro pgrx-spi rust+sql Interop between Rust and SQL

Comments

@workingjubilee
Copy link
Member

workingjubilee commented Apr 17, 2024

brain recently tied together the rest of the connections necessary for implementing all of #1337 and thus finishing out the fixes that ultimately address the soundness issues revealed by the Spi bugs we found.

@workingjubilee workingjubilee changed the title Draw the rest of the ~~owl~~ new ABI-handling framework Draw the rest of the ̶o̶w̶l̶ new ABI-handling framework Apr 17, 2024
@workingjubilee workingjubilee added bug Something isn't working enhancement New feature or request ffi rust+sql Interop between Rust and SQL macro pgrx-spi pgrx-array pgrx-tuple E_TOO_MANY_LABELS labels Apr 17, 2024
@workingjubilee
Copy link
Member Author

We still need to introduce some transition code here for cases where it isn't as obvious a breakage, but implementing the new RetAbi was more successful in preserving functionality than I expected, and most of the errors produced are straightforward type errors now, so I'm making more hard breaks.

@workingjubilee
Copy link
Member Author

The first piece of this has slid into place, as #1731 now makes it possible, in conjunction with #1701, to have a single pg_extern function be lifetime-checked on its arguments and return types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working E_TOO_MANY_LABELS enhancement New feature or request ffi macro pgrx-spi rust+sql Interop between Rust and SQL
Projects
None yet
Development

No branches or pull requests

1 participant