Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented DerefMut for PgRelation #1956

Closed

Conversation

YohDeadfall
Copy link
Contributor

Closes #1955, but it still makes sense to implement pgstat macros as functions.

@eeeebbbbrrrr
Copy link
Contributor

I appreciate the effort, but I'm not sure making PgRelation mutable is really a great idea. Doing so implies that those mutations actually do things, and in most cases they don't.

If someone wants to port those pg_stat_count_* macros, I'd happily merge that. Seems I could use them in my day job, so it might be me that ends up doing it eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose pgstat_count_index_scan and friends, or make PgRelation implement DerefMut
2 participants