Phalcon 2.0.* - creating object does not set model snapshots.

[temuri416]

Hi,

My model:

class Robots extends Model
{
    public function initialize()
    {
        $this->keepSnapshots(true);
    }
}

Immediately after creating a new instance of model, its snapshot is blank.

That prevents me from checking whether a field has been updated if I decide to update it later during the same request.

Snapshots only get set when loading a model. But they should also be set after a new model is created.

Thanks!

[ashpumpkin]

+1, but I think it's not a bug, but a very annoying feature. Would be very cool if someone will fix it

[temuri416]

Snapshot should also be refreshed when Model is saved/updated.

[mzf]

Old issue. From 1.3.x

[ruudboon]

Refreshing the object doesn't help.

<?php
$model = new MyModel();
$model->name = "test";
$model->save();
$model->refresh();

I solved this by completely reloading the object :(

<?php
$model = new MyModel();
$model->name = "test";
$model->save();
$model = MyModel::findFirst($model->payment_id);

[sergeyklay]

@ruudboon yeah 😕 https://github.com/sergeyklay/incubator/blob/2.0.x/Library/Phalcon/Mvc/Model/Behavior/NestedSet.php#L338

[ruudboon]

I'm sorry @sergeyklay I don't understand your feedback.

[sergeyklay]

I mean that this is a known issue and I too just had to use this trick

[ruudboon]

Ah sorry! Now I see. Completely clear. Hope to get some time soon to contribute to Phalcon. Love this project.

[temuri416]

@andresgutierrez

Any update on this? Do you plan to implement it in 2.1?

Thanks!

[andrew-demb]

Up.
This will be very helpful for development, but if now implement the feature it can break some applications.

@andresgutierrez, can you give us a feedback about this?

[temuri416]

@sergeyklay Is this on your radar? :)

[Jurigag]

No because 2.0.x is no longer supported. I guess in phalcon 3.0.x we can fix this :D

[temuri416]

Sorry, I wasn't expecting this to be fixed in 2.0.x :-) Any hope for this go to on 3.x branch?

[VeryStrongFingers]

My work around for now is using a base mode class, with the 'afterCreate' method

<?php
class BaseModel {
    //...

    public function afterCreate()
    {
        // I'm using parent because the child classes overload toArray(). For most, $this->toArray() would suffice
        $this->setSnapshotData(parent::toArray());
    }
}

class SomeModel extends BaseModel {

}

$hello = new SomeModel();
if ($hello->create()) {
    var_dump($hello->hasSnapshotData()); //Returns true
}

[Jurigag]

I made PR with fix for this, let me know what you think.

[sergeyklay]

Fixed in the 3.1.x branch.