Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file observations #7

Open
Standaa opened this issue Jul 2, 2024 · 0 comments
Open

Config file observations #7

Standaa opened this issue Jul 2, 2024 · 0 comments

Comments

@Standaa
Copy link

Standaa commented Jul 2, 2024

Hello PB team,
Quick suggestion.
I think it would be much nicer if you could pass the secret upon initializing the library or make it an env variable.

Motivations:

  1. Dealing with updating config file secrets in a Dockerfile after loading a vault like Hashicorp or dotenv is clunky
  2. Variable leaks into the the docker image config file
  3. You cannot commit the config file with the secret. You would have to commit an example config file to avoid devs accidentally comitting the secret. One more thing people have to configure etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant