Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeppolValidationAUNZ 101 still use IReadableResource for 100 #12

Closed
jamalsa opened this issue Mar 18, 2020 · 3 comments
Closed

PeppolValidationAUNZ 101 still use IReadableResource for 100 #12

jamalsa opened this issue Mar 18, 2020 · 3 comments
Assignees
@phax
Labels
bug

Comments

@jamalsa
Copy link

jamalsa commented Mar 18, 2020

Executor set for VESID 101 still use IReadableResource for 100. Shouldnt it use 101 version?:

https://github.com/phax/ph-bdve/blob/e3b051f9ef3af8a4fc56dc455ac169c58f81bc8a/ph-bdve-peppol/src/main/java/com/helger/bdve/peppol/PeppolValidationAUNZ.java#L180-L244
@phax phax self-assigned this Mar 18, 2020
@phax phax added the bug label Mar 18, 2020
@phax
Copy link
Owner

phax commented Mar 18, 2020

You are totally right. Thanks for pointing that out

@phax phax closed this as completed in 2d40117 Mar 18, 2020
@phax
Copy link
Owner

phax commented Mar 18, 2020

Fixed in 5.2.9 release

@jamalsa
Copy link
Author

jamalsa commented Mar 18, 2020

Thank you @phax for your quick response and release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phax phax

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamalsa @phax