Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve swagger directly from the server. #143

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Serve swagger directly from the server. #143

merged 1 commit into from
Aug 26, 2021

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Aug 26, 2021

Fixes #132.

@balhoff balhoff merged commit 083b994 into master Aug 26, 2021
@balhoff balhoff deleted the issue-132 branch August 26, 2021 17:04
@rpgoldman
Copy link
Contributor

@balhoff That's awesome! Question: how soon will this appear in the latest docker image? Does that happen automagically with CI?

@balhoff
Copy link
Member Author

balhoff commented Aug 26, 2021

I'm not exactly sure... issue #58 suggests that hasn't been working automatically. @hlapp do you have any new info on why that doesn't work?

@hlapp
Copy link
Member

hlapp commented Aug 26, 2021

Docker Hub has discontinued automatic builds for non-paid accounts in June. So none of these are auto-updating anymore.

The right change would be, I think, to migrate to the GitHub container repository and GitHub actions for auto-build instead, but I've not had time to look into that.

@rpgoldman
Copy link
Contributor

@hlapp @balhoff Would you mind kicking DockerHub manually so I could try the new version?

Or would you prefer I make a fork and do the Docker building myself?

@hlapp
Copy link
Member

hlapp commented Aug 26, 2021

@rpgoldman I don't think that feature is available anymore. (If you know it is, let us know how to get there?) One has to push the image to Docker Hub, meaning, you have to build the container yourself.

If you have Docker installed, you should actually be able to build the container locally from a checkout of the repository.

@rpgoldman
Copy link
Contributor

@hlapp I have done that, thanks. Please see my issue #146 and MR #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for Enhancement: Add Swagger to the server
3 participants