Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-ordering and re-labeling of the PhET Menu items #218

Closed
terracoda opened this issue Apr 6, 2017 · 4 comments
Closed

Re-ordering and re-labeling of the PhET Menu items #218

terracoda opened this issue Apr 6, 2017 · 4 comments
Assignees

Comments

@terracoda
Copy link
Contributor

In phetsims/a11y-research#12 we extensively discussed reordering the item, clarifying the label text, and adding new icons for the PhET Menu.

If time allows, is it possible to update the order and the labels, and leave the icons and help text for a later update?

Final order and content for labels and help text copied here from phetsims/a11y-research#12 (comment)

  • Keyboard Shortcuts: Tips on how to use this sim with a keyboard.
  • PhET Menu: Tools and links for this sim.

Then the actual menu items in the the PhET Menu

  • View Options...
  • Check for Updates (check square icon with alt text "Already up to date.")
  • Take Screenshot (camera icon)
  • Full Screen (full screen icon)
  • Report Problem (email icon)
  • About this Sim...

Visual separation here

  • PhET Website

Note there are 2 icons for Check for Updates

  • Check for Updates (exclamation triangle icon with alt text: "Update available.")
@jessegreenberg
Copy link
Contributor

@terracoda I would recommend waiting and handling changes to the PhET menu at one time. Changes like this to common components will require review from other team members and it will be more efficient to do that once.

Also, the issue list for this sim is growing and we are shooting for a release in ~2 weeks. I don't think we will have the time to modify the PhET menu now, but we can certainly do so after the sim has been released. @emily-phet what do you think?

@emily-phet
Copy link

@jessegreenberg @terracoda I agree with pausing on this until after JT is released. I think people will understand if the changes in the PhET menu come later.

@jessegreenberg
Copy link
Contributor

Ok, thanks @emily-phet. Closing this issue since the modifications will be continued in phetsims/a11y-research#12.

@terracoda
Copy link
Contributor Author

@jessegreenberg, @emily-phet ok. I agree changes that affect other sims is best to do all at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants