You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactor and rename variables in the src/models/ such that they match the variables defined in the PDF. This will make the code easier to maintain and perhaps help others port to other languages.
e.g. sigSqToCiq should probably be some variation of qEta, since it's related to ηq defined on page 287, §3.1.1
The unit tests should protect you from making any catastrophic changes.
The text was updated successfully, but these errors were encountered:
Please ask questions if you get stuck on anything. I would suggest a different and separate PRs for each model, and perhaps another that renames config vars to be more in line with the paper. I would prefer multiple smaller, incremental PRs.
philihp
changed the title
Rename variables to Match PDF
Rename variables to match paper
Mar 1, 2022
src/models/
such that they match the variables defined in the PDF. This will make the code easier to maintain and perhaps help others port to other languages.sigSqToCiq
should probably be some variation ofqEta
, since it's related to ηq defined on page 287, §3.1.1The text was updated successfully, but these errors were encountered: