Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added the AMI to machine setup info to runner workflows. #2451

Merged
merged 7 commits into from
Oct 7, 2022
Merged

feat: Added the AMI to machine setup info to runner workflows. #2451

merged 7 commits into from
Oct 7, 2022

Conversation

GuptaNavdeep1983
Copy link
Contributor

This PR adds the AMI Id for the runner machine to github workflows.

@npalm
Copy link
Member

npalm commented Sep 22, 2022

What other values would be nice to set? For example OS or linux distro?

Like the GitHub hosted runners, group OS, group image

@npalm npalm self-requested a review September 22, 2022 14:45
@npalm
Copy link
Member

npalm commented Oct 6, 2022

@GuptaNavdeep1983 can you check the comments please?

npalm
npalm previously approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @ScottGuymer can you have a quick look on the windows scripts?

@npalm npalm dismissed their stale review October 7, 2022 08:56

will run first a quick test

@npalm npalm changed the title feat: Added the Machine setup info to runner workflows. feat: Added the AMI to machine setup info to runner workflows. Oct 7, 2022
npalm
npalm requested changes Oct 7, 2022
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some small improvements in the suggestions, tested with the default example

modules/runners/templates/start-runner.ps1 Outdated Show resolved Hide resolved
modules/runners/templates/start-runner.sh Outdated Show resolved Hide resolved
GuptaNavdeep1983 and others added 3 commits October 7, 2022 09:26
@GuptaNavdeep1983 @npalm
Update modules/runners/templates/start-runner.ps1
9e67060 
Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
@GuptaNavdeep1983 @npalm
Update modules/runners/templates/start-runner.sh
a748860 
Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
@GuptaNavdeep1983
Merge branch 'develop' into features/add-machine-details-to-workflows
5bc6622
@GuptaNavdeep1983 GuptaNavdeep1983 requested a review from npalm October 7, 2022 13:27
@GuptaNavdeep1983 @ScottGuymer
Update modules/runners/templates/start-runner.ps1
944bc73 
Co-authored-by: Scott Guymer <scott.guymer@philips.com>
npalm
npalm approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, nice job!

@npalm npalm merged commit e197cbd into develop Oct 7, 2022
@npalm npalm deleted the features/add-machine-details-to-workflows branch October 7, 2022 20:57
forest-releaser bot pushed a commit that referenced this pull request Oct 12, 2022
@semantic-release-bot
chore(release): 1.12.0 [skip ci]
ffc2e38 
## [1.12.0](v1.11.0...v1.12.0) (2022-10-12)

### Features

* Added the AMI to machine setup info to runner workflows. ([#2451](#2451)) ([e197cbd](e197cbd))
* **images:** add ami for windows core 2022 ([#2390](#2390)) ([97707c2](97707c2))
* Log workflow id in webhook ([#2511](#2511)) ([204acf1](204acf1))
* Security improvements, add option to disable userdata logging ([9a9e2ee](9a9e2ee)), closes [#1019](#1019) [#899](#899) [#1080](#1080) [#748](#748) [#1112](#1112) [#903](#903) [#1082](#1082) [#1133](#1133) [#2](#2) [#1204](#1204) [#1219](#1219) [#1202](#1202) [#1202](#1202) [#1135](#1135) [#1164](#1164) [#1154](#1154) [#1207](#1207) [#1203](#1203) [#1247](#1247) [#1222](#1222) [#1244](#1244) [#1223](#1223) [#1254](#1254) [#1286](#1286) [#1287](#1287) [#1278](#1278) [#1354](#1354) [#1357](#1357) [#1356](#1356) [#1228](#1228) [#1324](#1324) [#1358](#1358) [#1377](#1377) [#1368](#1368) [#1381](#1381) [#1415](#1415) [#1416](#1416) [#1423](#1423) [#1399](#1399) [#1401](#1401) [#1444](#1444) [#1480](#1480) [#1478](#1478) [#1479](#1479) [#1476](#1476) [#1537](#1537) [#1538](#1538) [#1541](#1541) [#1542](#1542) [#1399](#1399) [#1444](#1444) [#1572](#1572) [#1556](#1556) [#1561](#1561) [#1525](#1525) [#1591](#1591) [#1577](#1577) [#1621](#1621) [#1611](#1611) [#1615](#1615) [#1624](#1624) [#1628](#1628) [#1647](#1647) [#1644](#1644) [#1673](#1673) [#1676](#1676) [#1716](#1716) [#1741](#1741) [#1738](#1738) [#1745](#1745) [#1718](#1718) [#1791](#1791) [github.com//pull/1816#issuecomment-1060650668](https://github.com/philips-labs/github.com/philips-labs/terraform-aws-github-runner/pull/1816/issues/issuecomment-1060650668) [#1816](#1816) [#1833](#1833) [#1798](#1798) [#1815](#1815) [#1838](#1838) [#1797](#1797) [#1839](#1839) [#1812](#1812) [#1854](#1854) [#1855](#1855) [#1845](#1845) [#1832](#1832) [#1859](#1859) [#1937](#1937) [#1969](#1969) [#1970](#1970) [#1954](#1954) [#2019](#2019) [#1739](#1739) [#2019](#2019) [#2024](#2024) [#2051](#2051) [#1858](#1858) [#2085](#2085) [#2121](#2121) [#2073](#2073) [#2146](#2146) [#2145](#2145) [#2147](#2147) [#2122](#2122) [#2123](#2123) [#2181](#2181) [#2207](#2207) [#2102](#2102) [#2214](#2214) [#2052](#2052) [#2074](#2074) [#2233](#2233) [#2288](#2288) [#2302](#2302) [#2291](#2291) [#2209](#2209) [#2315](#2315) [#2314](#2314) [#2103](#2103) [#2345](#2345) [#2387](#2387) [#2371](#2371) [#2431](#2431) [#2369](#2369) [#2346](#2346) [#2325](#2325) [#2434](#2434) [#2455](#2455)

### Bug Fixes

* Remove resource group from module ([#2512](#2512)) ([2628352](2628352))
enverus-github-action-app-token bot pushed a commit to enverus-cts/terraform-aws-github-runner that referenced this pull request Nov 2, 2022
@semantic-release-bot
chore(release): 1.0.0-develop.1 [skip ci]
3047f61 
## [1.0.0-develop.1](v0.32.0...v1.0.0-develop.1) (2022-11-02)

### ⚠ BREAKING CHANGES

* var.volume_size replaced by var.block_device_mappings
* The module is upgraded to AWS Terraform provider 4.x

### Features

*  Add associate_public_ip_address variable to windows AMI too ([philips-labs#1819](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1819)) ([0b8e1fc](0b8e1fc)), closes [/github.com/philips-labs/pull/1816#issuecomment-1060650668](https://github.com/enverus-cts//github.com/philips-labs/terraform-aws-github-runner/pull/1816/issues/issuecomment-1060650668)
* Add associate_public_ip_address variable ([philips-labs#1816](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1816)) ([052e9f8](052e9f8))
* Add option for ephemeral to check builds status before scaling ([philips-labs#1854](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1854)) ([7eb0bda](7eb0bda))
* Add option for KMS encryption for cloudwatch log groups ([philips-labs#1833](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1833)) ([3f1a67f](3f1a67f))
* Add option to disable lambda to sync runner binaries ([philips-labs#2314](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2314)) ([9f7d32d](9f7d32d))
* Add option to enable access log for API gateway ([philips-labs#2387](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2387)) ([fcd9fba](fcd9fba))
* Add option to enable detailed monitoring for runner launch template ([philips-labs#2024](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2024)) ([e73a267](e73a267))
* Add option to match some of the labes instead of all [philips-labs#2122](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2122) ([philips-labs#2123](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2123)) ([c5e3c21](c5e3c21))
* Add options extra option to ebs block device mapping ([philips-labs#2052](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2052)) ([7cd2524](7cd2524))
* Add output image id used in launch template ([philips-labs#1676](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1676)) ([a49fab4](a49fab4))
* Add possibility to create multiple ebs ([philips-labs#1845](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1845)) ([7a2ca0d](7a2ca0d))
* add s3_location_runner_distribution var as expandable for userdata ([philips-labs#2371](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2371)) ([05fe737](05fe737))
* Add SQS queue resource policy to improve security ([philips-labs#1798](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1798)) ([96def9a](96def9a))
* Add Support for Alternative Partitions in ARNs (like govcloud) ([philips-labs#1815](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1815)) ([0ba06c8](0ba06c8))
* Add ubuntu-jammy example image based on existing ubuntu-focal ([philips-labs#2102](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2102)) ([486ae91](486ae91))
* Add variable to specify custom commands while building the AMI ([philips-labs#1838](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1838)) ([8f9c342](8f9c342))
* Added the AMI to machine setup info to runner workflows. ([philips-labs#2451](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2451)) ([e197cbd](e197cbd))
* Download runner release via latest release API ([philips-labs#2455](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2455)) ([e75e092](e75e092))
* Enable node16 default ([philips-labs#2074](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2074)) ([58aa5ed](58aa5ed))
* Encrypted data at REST on SQS by default ([philips-labs#2431](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2431)) ([7f3f4bf](7f3f4bf))
* Experimental feature - Duplicate workflow job event to extra queue ([philips-labs#2268](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2268)) ([985e722](985e722))
* Experimental feature - Duplicate workflow job event to extra queue ([philips-labs#2268](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2268)) ([ac046b8](ac046b8))
* **images:** add ami for windows core 2022 ([philips-labs#2390](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2390)) ([97707c2](97707c2))
* **images:** Added ubuntu-focual example packer configuration ([philips-labs#1644](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1644)) ([997b171](997b171))
* **images:** Allow passing instance type when building windows image ([philips-labs#2369](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2369)) ([eca23bf](eca23bf))
* Improve syncer s3 kms encryption ([38ed5be](38ed5be))
* Log workflow id in webhook ([philips-labs#2511](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2511)) ([204acf1](204acf1))
* Parameterise delete_on_termination ([philips-labs#1758](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1758)) ([6282351](6282351)), closes [philips-labs#1745](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1745)
* Remove var.volume_size in favour of var.block_device_mappings ([4e97048](4e97048))
* Replace environment variable by prefix ([philips-labs#1858](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1858)) ([e2f9a27](e2f9a27))
* **runner:** Ability to disable default runner security group creation ([philips-labs#1718](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1718)) ([94779f8](94779f8))
* **runner:** Add option to disable auto update ([philips-labs#1791](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1791)) ([c2a834f](c2a834f))
* **runners:** Add support for looking up runner AMI ID from an SSM parameter at instance launch time ([philips-labs#2520](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2520)) ([68e2381](68e2381))
* Security improvements, add option to disable userdata logging ([9a9e2ee](9a9e2ee)), closes [#1019](#1019) [#899](#899) [#1080](#1080) [#748](#748) [#1112](#1112) [#903](#903) [#1082](#1082) [#1133](#1133) [#2](#2) [#1204](#1204) [#1219](#1219) [#1202](#1202) [#1202](#1202) [#1135](#1135) [#1164](#1164) [#1154](#1154) [#1207](#1207) [#1203](#1203) [#1247](#1247) [#1222](#1222) [#1244](#1244) [#1223](#1223) [#1254](#1254) [philips-labs#1286](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1286) [philips-labs#1287](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1287) [philips-labs#1278](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1278) [philips-labs#1354](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1354) [philips-labs#1357](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1357) [philips-labs#1356](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1356) [#1228](#1228) [philips-labs#1324](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1324) [philips-labs#1358](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1358) [philips-labs#1377](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1377) [philips-labs#1368](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1368) [philips-labs#1381](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1381) [philips-labs#1415](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1415) [philips-labs#1416](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1416) [philips-labs#1423](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1423) [philips-labs#1399](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1399) [philips-labs#1401](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1401) [philips-labs#1444](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1444) [philips-labs#1480](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1480) [philips-labs#1478](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1478) [philips-labs#1479](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1479) [philips-labs#1476](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1476) [philips-labs#1537](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1537) [philips-labs#1538](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1538) [philips-labs#1541](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1541) [philips-labs#1542](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1542) [philips-labs#1399](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1399) [philips-labs#1444](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1444) [philips-labs#1572](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1572) [philips-labs#1556](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1556) [philips-labs#1561](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1561) [philips-labs#1525](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1525) [philips-labs#1591](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1591) [philips-labs#1577](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1577) [philips-labs#1621](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1621) [philips-labs#1611](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1611) [philips-labs#1615](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1615) [philips-labs#1624](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1624) [philips-labs#1628](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1628) [philips-labs#1647](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1647) [philips-labs#1644](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1644) [philips-labs#1673](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1673) [philips-labs#1676](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1676) [philips-labs#1716](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1716) [philips-labs#1741](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1741) [philips-labs#1738](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1738) [philips-labs#1745](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1745) [philips-labs#1718](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1718) [philips-labs#1791](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1791) [github.com/philips-labs/pull/1816#issuecomment-1060650668](https://github.com/enverus-cts/github.com/philips-labs/terraform-aws-github-runner/pull/1816/issues/issuecomment-1060650668) [philips-labs#1816](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1816) [philips-labs#1833](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1833) [philips-labs#1798](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1798) [philips-labs#1815](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1815) [philips-labs#1838](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1838) [philips-labs#1797](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1797) [philips-labs#1839](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1839) [philips-labs#1812](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1812) [philips-labs#1854](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1854) [philips-labs#1855](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1855) [philips-labs#1845](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1845) [philips-labs#1832](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1832) [philips-labs#1859](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1859) [philips-labs#1937](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1937) [philips-labs#1969](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1969) [philips-labs#1970](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1970) [philips-labs#1954](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1954) [philips-labs#2019](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2019) [philips-labs#1739](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1739) [philips-labs#2019](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2019) [philips-labs#2024](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2024) [philips-labs#2051](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2051) [philips-labs#1858](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1858) [philips-labs#2085](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2085) [philips-labs#2121](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2121) [philips-labs#2073](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2073) [philips-labs#2146](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2146) [philips-labs#2145](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2145) [philips-labs#2147](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2147) [philips-labs#2122](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2122) [philips-labs#2123](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2123) [philips-labs#2181](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2181) [philips-labs#2207](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2207) [philips-labs#2102](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2102) [philips-labs#2214](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2214) [philips-labs#2052](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2052) [philips-labs#2074](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2074) [philips-labs#2233](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2233) [philips-labs#2288](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2288) [philips-labs#2302](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2302) [philips-labs#2291](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2291) [philips-labs#2209](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2209) [philips-labs#2315](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2315) [philips-labs#2314](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2314) [philips-labs#2103](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2103) [philips-labs#2345](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2345) [philips-labs#2387](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2387) [philips-labs#2371](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2371) [philips-labs#2431](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2431) [philips-labs#2369](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2369) [philips-labs#2346](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2346) [philips-labs#2325](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2325) [philips-labs#2434](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2434) [philips-labs#2455](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2455)
* Support arm64 lambda functions ([philips-labs#2121](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2121)) ([9e2a7b6](9e2a7b6))
* Support AWS 4.x Terraform provider ([philips-labs#1739](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1739)) ([cfb6da2](cfb6da2))
* Support multi runner process support for runner scale down. ([philips-labs#1859](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1859)) ([3658d6a](3658d6a))
* Support Node16 for AWS Lambda ([philips-labs#2073](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2073)) ([68a2014](68a2014))
* Support s3 bucket logging for distribution cache bucket ([philips-labs#2430](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2430)) ([69578e0](69578e0))
* Webhook accept jobs where not all labels are provided in job. ([philips-labs#2209](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2209)) ([6d9116f](6d9116f))

### Bug Fixes

* added server_side_encryption key to download trigger for distribution ([philips-labs#2207](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2207)) ([404e3b6](404e3b6))
* Autoupdate should be disabled by default ([philips-labs#1797](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1797)) ([828bed6](828bed6))
* Avoid non semantic commontes can be merged. ([philips-labs#1969](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1969)) ([ad1c872](ad1c872))
* Create SQS DLQ policy only if DLQ is created ([philips-labs#1839](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1839)) ([c88a005](c88a005))
* don't apply extra labels unless defined ([philips-labs#2181](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2181)) ([c0b11bb](c0b11bb))
* Don't delete busy runners ([philips-labs#1832](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1832)) ([0e9b083](0e9b083))
* **examples:** Update AMI filter ([philips-labs#1673](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1673)) ([39c019c](39c019c))
* **examples:** Upgrading ubuntu example to 22.04 ([philips-labs#2250](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2250)) ([d4b7650](d4b7650)), closes [philips-labs#2103](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2103)
* Ignore case for runner labels. ([philips-labs#2315](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2315)) ([014985a](014985a))
* **images:** avoid wrong AMI could be selected for ubuntu focal ([philips-labs#2214](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2214)) ([76be94b](76be94b))
* Incorrect path of Runner logs ([philips-labs#2233](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2233)) ([98eff98](98eff98))
* Limit AWS Terraform Provider to 3.* ([philips-labs#1741](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1741)) ([0cf2b5d](0cf2b5d))
* Outputs for pool need to account for complexity ([philips-labs#1970](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1970)) ([2d92906](2d92906))
* Preventing that lambda webhook fails when it tries to process an installation_repositories event ([philips-labs#2288](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2288)) ([8656c83](8656c83))
* Remove asterik in permission for runner lambda to describe instances ([9b9da03](9b9da03))
* Remove resource group from module ([philips-labs#2512](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2512)) ([2628352](2628352))
* replaced old environment variable ([philips-labs#2146](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2146)) ([f2072f7](f2072f7))
* replacing deprecated set-output in workflow ([philips-labs#2564](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2564)) ([aa0afdd](aa0afdd))
* Retention days was used instead of kms key id for pool ([philips-labs#1855](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1855)) ([aa29d93](aa29d93))
* **runner:** Cannot disable cloudwatch agent ([philips-labs#1738](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1738)) ([0f798ca](0f798ca))
* **runner:** Don't treat the string "false" as true. ([philips-labs#2051](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2051)) ([b67c7dc](b67c7dc))
* **runners:** Fetch instance environment tag though metadata ([philips-labs#2346](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2346)) ([27db290](27db290))
* **runners:** Pass allocation strategy ([philips-labs#2345](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2345)) ([68d3445](68d3445))
* **runners:** Set the default Windows AMI to Server 2022 ([philips-labs#2325](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2325)) ([78e99d1](78e99d1))
* set explicit permissions on s3 for syncer lambda ([philips-labs#2145](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2145)) ([aa7edd1](aa7edd1))
* set kms key on aws_s3_object when encryption is enabled ([philips-labs#2147](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2147)) ([b4dc706](b4dc706))
* Set the minimal AWS provider to 3.50 ([philips-labs#1937](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1937)) ([16095d8](16095d8))
* **syncer:** Fix for windows binaries in action runner syncer ([philips-labs#1716](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1716)) ([63e0e27](63e0e27))
* Update ubuntu example to fix /opt/hostedtoolcache ([philips-labs#2302](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2302)) ([8eea748](8eea748))
* Upgrade Amazon base AMI to Amazon Linux 2 kernel 5x ([philips-labs#1812](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1812)) ([9aa5532](9aa5532))
* Volume size is ingored ([philips-labs#2014](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2014)) ([b733248](b733248)), closes [philips-labs#1954](https://github.com/enverus-cts/terraform-aws-github-runner/issues/1954)
* Webhook lambda misleading log ([philips-labs#2291](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2291)) ([c6275f9](c6275f9))
* **webhook:** Use `x-hub-signature-256` header as default ([philips-labs#2434](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2434)) ([9c3e495](9c3e495))
* Wrong block device mapping ([philips-labs#2019](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2019)) ([185ef20](185ef20))
* Wrong block device mapping ([philips-labs#2019](https://github.com/enverus-cts/terraform-aws-github-runner/issues/2019)) ([c42a467](c42a467))
@forest-releaser forest-releaser bot mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm npalm approved these changes

@ScottGuymer ScottGuymer Awaiting requested review from ScottGuymer

Assignees

@GuptaNavdeep1983 GuptaNavdeep1983

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuptaNavdeep1983 @npalm @ScottGuymer @navdeepg2021