Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runners): allow to use a shared encrypted AMI #2933

Merged
merged 9 commits into from
Mar 8, 2023

Conversation

v-rosa
Copy link
Contributor

@v-rosa v-rosa commented Feb 7, 2023

Currently its not possible to use an AMI encrypted using an external KMS key.

Related to #2927

Co-authored with @rsmolinski

@npalm npalm self-requested a review February 10, 2023 13:01
@v-rosa v-rosa force-pushed the allow-using-encrypted-ami branch from faf7cd7 to 8756d08 Compare February 10, 2023 13:43
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-rosa thanks for you work. In general looks good. Added a few comments.

modules/runners/main.tf Show resolved Hide resolved
modules/runners/scale-up.tf Show resolved Hide resolved
modules/runners/policies/lambda-scale-up.json Show resolved Hide resolved
modules/runners/policies/lambda-scale-down.json Outdated Show resolved Hide resolved
@npalm npalm changed the title feat: allow to use a shared encrypted AMI feat(runners): allow to use a shared encrypted AMI Feb 17, 2023
@v-rosa v-rosa force-pushed the allow-using-encrypted-ami branch from dae137e to 8f0b51f Compare February 22, 2023 11:22
@v-rosa v-rosa force-pushed the allow-using-encrypted-ami branch from 8f0b51f to 415bc8b Compare February 22, 2023 11:24
@npalm
Copy link
Member

npalm commented Mar 8, 2023

@v-rosa @rsmolinski Thanks!

@npalm npalm merged commit 5514c72 into philips-labs:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants