-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runners): allow to use a shared encrypted AMI #2933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-rosa
force-pushed
the
allow-using-encrypted-ami
branch
from
February 10, 2023 13:43
faf7cd7
to
8756d08
Compare
npalm
requested changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@v-rosa thanks for you work. In general looks good. Added a few comments.
npalm
changed the title
feat: allow to use a shared encrypted AMI
feat(runners): allow to use a shared encrypted AMI
Feb 17, 2023
v-rosa
force-pushed
the
allow-using-encrypted-ami
branch
from
February 22, 2023 11:22
dae137e
to
8f0b51f
Compare
v-rosa
force-pushed
the
allow-using-encrypted-ami
branch
from
February 22, 2023 11:24
8f0b51f
to
415bc8b
Compare
npalm
approved these changes
Mar 8, 2023
@v-rosa @rsmolinski Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently its not possible to use an AMI encrypted using an external KMS key.
Related to #2927
Co-authored with @rsmolinski