fix(runners): increase the log level to WARN when using the enable_job_queued_check parameter #3046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme section detailing the
enable_job_queued_check
makes it an appealing function, but it was unclear to me that it could cause some issues when used with ephemeral runners and matrix workflows.It is particularly challenging to notice for organizations with a very large number of repositories, at times with low activity the issue is not present, but when matrix jobs are started or when multiple repositories are triggering jobs around the same time window (such as cron'd workflow), this issue is more likely to be faced.
For example, on the execution that allowed me to find the cause, when starting a matrix of 9 jobs, 4 of them were actually triggering this log message:
This log message, aside from being one amongst many other
INFO
messages, does not provide many details about the consequences.I suggest bumping the level to
WARN
and adding more details in the message itself.Related discussion: #2931