fix: Add missing SG and subnet configuration for Job Retry lambda #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @npalm , this is a simple bug fix. Any chance you can take a quick look? Thank you! |
|
Hi @npalm @stuartp44 can you help review this PR? 🙏 |
npalm
pushed a commit
that referenced
this pull request
Sep 21, 2024
🤖 I have created a release *beep* *boop* --- ## [5.16.1](v5.16.0...v5.16.1) (2024-09-21) ### Bug Fixes * Add missing SG and subnet configuration for Job Retry lambda ([#4114](#4114)) ([7095487](7095487)) * **lambda:** bump @aws-sdk/client-ec2 from 3.637.0 to 3.641.0 in /lambdas in the aws group ([#4106](#4106)) ([20f51a1](20f51a1)) * **lambda:** bump @octokit/auth-app from 6.1.1 to 6.1.2 in /lambdas in the octokit group ([#4117](#4117)) ([6e6bd98](6e6bd98)) * **lambda:** bump the aws group in /lambdas with 5 updates ([#4116](#4116)) ([4a8826b](4a8826b)) * **lambda:** bump the aws group in /lambdas with 6 updates ([#4128](#4128)) ([f6164e7](f6164e7)) * **lambda:** bump the aws-powertools group in /lambdas with 4 updates ([#4129](#4129)) ([ab2605f](ab2605f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
jgutierrezglez
pushed a commit
to jgutierrezglez/terraform-aws-github-runner
that referenced
this pull request
Sep 23, 2024
…ilips-labs#4114) While the Security group IDs and Subnet IDs can be configured in the Job-retry lambda, the `config` variable did not accept it. I rectify the type definition in the variable. Additionally, I also updated the description of the variable for accuracy.
jgutierrezglez
pushed a commit
to jgutierrezglez/terraform-aws-github-runner
that referenced
this pull request
Sep 23, 2024
🤖 I have created a release *beep* *boop* --- ## [5.16.1](philips-labs/terraform-aws-github-runner@v5.16.0...v5.16.1) (2024-09-21) ### Bug Fixes * Add missing SG and subnet configuration for Job Retry lambda ([philips-labs#4114](philips-labs#4114)) ([7095487](philips-labs@7095487)) * **lambda:** bump @aws-sdk/client-ec2 from 3.637.0 to 3.641.0 in /lambdas in the aws group ([philips-labs#4106](philips-labs#4106)) ([20f51a1](philips-labs@20f51a1)) * **lambda:** bump @octokit/auth-app from 6.1.1 to 6.1.2 in /lambdas in the octokit group ([philips-labs#4117](philips-labs#4117)) ([6e6bd98](philips-labs@6e6bd98)) * **lambda:** bump the aws group in /lambdas with 5 updates ([philips-labs#4116](philips-labs#4116)) ([4a8826b](philips-labs@4a8826b)) * **lambda:** bump the aws group in /lambdas with 6 updates ([philips-labs#4128](philips-labs#4128)) ([f6164e7](philips-labs@f6164e7)) * **lambda:** bump the aws-powertools group in /lambdas with 4 updates ([philips-labs#4129](philips-labs#4129)) ([ab2605f](philips-labs@ab2605f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the Security group IDs and Subnet IDs can be configured in the Job-retry lambda, the
configvariable did not accept it. I rectify the type definition in the variable. Additionally, I also updated the description of the variable for accuracy.