Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add thumbv7em-none-eabihf for cortex-m floating point processors #625

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

richardapeters
Copy link
Contributor

@richardapeters richardapeters commented Oct 31, 2024

Pull Request

Description of changes

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@richardapeters richardapeters requested a review from a team as a code owner October 31, 2024 09:06
Copy link

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:775e22a0f62075d776ac5ebed05ea879467a82b170e448f4c241123d3404b343

OS/Platform Previous Size Current Size Delta
linux/amd64 650.42M 650.42M 0.00 (+0.00%)
linux/arm64 643.10M 643.10M 0.00 (+0.00%)

Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.05s
✅ DOCKERFILE hadolint 2 0 0.48s
✅ GHERKIN gherkin-lint 2 0 0.73s
✅ JSON npm-package-json-lint yes no 0.48s
✅ JSON prettier 15 2 0 0.63s
✅ JSON v8r 14 0 18.16s
✅ MARKDOWN markdownlint 8 0 0 0.89s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.22s
✅ REPOSITORY checkov yes no 16.27s
✅ REPOSITORY gitleaks yes no 0.59s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.76s
✅ REPOSITORY secretlint yes no 1.6s
✅ REPOSITORY syft yes no 0.53s
✅ REPOSITORY trivy yes no 14.09s
✅ REPOSITORY trivy-sbom yes no 0.12s
✅ REPOSITORY trufflehog yes no 2.41s
✅ SPELL lychee 58 0 1.23s
✅ YAML prettier 21 0 0 1.0s
✅ YAML v8r 21 0 13.44s
✅ YAML yamllint 21 0 0.46s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link
Contributor

Test Results

 2 files  ±0   2 suites  ±0   1m 14s ⏱️ +6s
29 tests +1  29 ✅ +1  0 💤 ±0  0 ❌ ±0 
31 runs  +1  31 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit e144c9a. ± Comparison against base commit 09fe055.

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:cea83247ee0f49b54b5cb0635d14fcec972ca46e0db5085e3760de8e128d0215

OS/Platform Previous Size Current Size Delta
linux/amd64 433.00M 449.21M 16.22M (+3.74%)
linux/arm64 572.52M 588.72M 16.21M (+2.83%)

@richardapeters richardapeters added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 17e13c8 Nov 1, 2024
25 checks passed
@richardapeters richardapeters deleted the feature/cortex-mf branch November 1, 2024 09:08
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Pull Request Report (#625)

Static measures

Description Value
Number of added lines 298
Number of deleted lines 1
Number of changed files 6
Number of commits 1
Number of reviews 3
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 2
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 1 Days
Time that was spend on the branch before the PR was created 26 Sec
Time that was spend on the branch before the PR was merged 1 Days
Time to merge after last review 5.6 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 24.7 Min
Total time spend in last status check run on PR 11.6 Min

Copy link
Contributor

github-actions bot commented Nov 7, 2024

🎉 Hooray! The changes in this pull request went live with the release of v5.5.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants