Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove deprecated grpc DialContext #444

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

reiinoldo
Copy link
Contributor

@reiinoldo reiinoldo commented Nov 27, 2024

Using the grpc NewClient resolves the following issue:
image
https://github.com/philips-software/logproxy/actions/runs/12041976555/job/33574829747

Test is passing:
image

No Issue more when running lint:
image

@reiinoldo reiinoldo requested a review from loafoe as a code owner November 27, 2024 19:12
@loafoe loafoe merged commit f271d5f into philips-software:main Dec 12, 2024
1 check passed
@loafoe
Copy link
Member

loafoe commented Dec 12, 2024

@reiinoldo awesome, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants